alexislefebvre /
LiipFunctionalTestBundle
These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
| 1 | <?php |
||
| 2 | |||
| 3 | namespace Liip\FunctionalTestBundle; |
||
| 4 | |||
| 5 | use Symfony\Bundle\FrameworkBundle\Client; |
||
| 6 | |||
| 7 | class QueryCountClient extends Client |
||
| 8 | { |
||
| 9 | /** @var QueryCounter */ |
||
| 10 | private $queryCounter; |
||
| 11 | |||
| 12 | 14 | public function setQueryCounter(QueryCounter $queryCounter) |
|
| 13 | { |
||
| 14 | 14 | $this->queryCounter = $queryCounter; |
|
| 15 | 14 | } |
|
| 16 | |||
| 17 | 5 | public function request( |
|
| 18 | $method, |
||
| 19 | $uri, |
||
| 20 | array $parameters = array(), |
||
| 21 | array $files = array(), |
||
| 22 | array $server = array(), |
||
| 23 | $content = null, |
||
| 24 | $changeHistory = true |
||
| 25 | ) { |
||
| 26 | 5 | $crawler = parent::request($method, $uri, $parameters, $files, $server, $content, $changeHistory); |
|
| 27 | |||
| 28 | 5 | if ($this->getProfile()) { |
|
| 29 | 5 | $this->queryCounter->checkQueryCount( |
|
| 30 | 5 | $this->getProfile()->getCollector('db')->getQueryCount() |
|
|
0 ignored issues
–
show
|
|||
| 31 | 5 | ); |
|
| 32 | 5 | } else { |
|
| 33 | // @codeCoverageIgnoreStart |
||
| 34 | echo "\n". |
||
| 35 | 'Profiler is disabled, it must be enabled for the '. |
||
| 36 | 'Query Counter. '. |
||
| 37 | 'See https://github.com/liip/LiipFunctionalTestBundle#query-counter'. |
||
| 38 | "\n"; |
||
| 39 | // @codeCoverageIgnoreEnd |
||
| 40 | } |
||
| 41 | |||
| 42 | 3 | return $crawler; |
|
| 43 | } |
||
| 44 | } |
||
| 45 |
Let’s take a look at an example:
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.
Available Fixes
Change the type-hint for the parameter:
Add an additional type-check:
Add the method to the interface: