MiddlewareTestClass::testMultipleMiddlewaresInOrderAndOmitMalformed() - Code Metrics - Inspection of "feature/Total refacctoring of the code and unit-te..." - alexdodonov/mezon-router - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( a4ddd3...82bd79 )

by Alex

created 2021-12-05 16:16 UTC

testMultipleMiddlewaresInOrderAndOmitMalformed() A

↳ Parent: MiddlewareTestClass

Complexity

Conditions	1
Paths	1

Size

Total Lines	74
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
eloc	34
c	1
b	1
f	0
dl	0
loc	74
rs	9.376
cc	1
nc	1
nop	0

How to fix Long Method

<?php
declare(strict_types = 1);
namespace Mezon\Router\Tests\Base;

use PHPUnit\Framework\TestCase;

/**
 *
 * @psalm-suppress PropertyNotSetInConstructor
 */
abstract class MiddlewareTestClass extends BaseRouterUnitTestClass
{

    /**
     * Default setup
     *
     * {@inheritdoc}
     * @see TestCase::setUp()
     */
    public function setUp(): void
    {
        $_SERVER['REQUEST_METHOD'] = 'GET';
    }

    /**
     * Testing middleware
     */
    public function testMiddleware(): void
    {
        // setup
        $route = '/route-with-middleware/';
        $router = $this->getRouter();
        $router->registerMiddleware('*', function () {
            return [
                1,
                2
            ];
        });
        $router->addRoute($route, function (int $i, int $j) {
            return [
                $i,
                $j
            ];
        });
        $router->registerMiddleware($route, function (int $i, int $j) {
            return [
                $i,
                $j
            ];
        });

        // test body
        /** @var array{0: int, 1: int} $result */
        $result = $router->callRoute($route);

        // assertions
        $this->assertEquals(1, $result[0]);
        $this->assertEquals(2, $result[1]);
    }

    /**
     * Testing multiple middlewares
     */
    public function testMultipleMiddlewaresInOrderAndOmitMalformed(): void
    {
        // setup
        $route = '/route/[i:id]';
        $router = $this->getRouter();

        $router->addRoute($route, function (string $route, array $parameters): array {
            return $parameters;
        });

        $router->registerMiddleware($route, /**
         *
         * @psalm-param string $route route
         * @psalm-param array{id: int} $parameters parameters
         */
        function (string $route, array $parameters) {
            $parameters['_second'] = $parameters['id'];
            $parameters['id'] += 9;

            return [
                $route,
                $parameters
            ];
        });

        // This middleware is broken, don't parse the result
        $router->registerMiddleware($route, function (string $route, array $parameters) {
            $parameters['_dont_set_this'] = true;

            return null;
        });

        $router->registerMiddleware($route, /**
         *
         * @psalm-param string $route
         *            route
         * @psalm-param array{id: int} $parameters parameters
         */
        function (string $route, array $parameters) {
            $parameters['_third'] = $parameters['id'];
            $parameters['id'] *= 2;

            return [
                $route,
                $parameters
            ];
        });

        $router->registerMiddleware('*', /**
         *
         * @psalm-param string $route
         *            route
         * @psalm-param array{id: int} $parameters parameters
         */
        function (string $route, array $parameters) {
            $parameters['_first'] = $parameters['id'];
            $parameters['id'] *= 2;

            return [
                $route,
                $parameters
            ];
        });

        // test body
        /** @var array<string, mixed> $result */
        $result = $router->callRoute('/route/1');

        // assertions
        $this->assertEquals(22, $result['id']);
        $this->assertEquals(1, $result['_first']);
        $this->assertEquals(2, $result['_second']);
        $this->assertEquals(11, $result['_third']);
        $this->assertTrue(empty($result['_dont_set_this']));
    }
}


1			<?php
2			declare(strict_types = 1);
3			namespace Mezon\Router\Tests\Base;
4
5			use PHPUnit\Framework\TestCase;
6
7			/**
8			*
9			* @psalm-suppress PropertyNotSetInConstructor
10			*/
11			abstract class MiddlewareTestClass extends BaseRouterUnitTestClass
12			{
13
14			/**
15			* Default setup
16			*
17			* {@inheritdoc}
18			* @see TestCase::setUp()
19			*/
20			public function setUp(): void
21			{
22			$_SERVER['REQUEST_METHOD'] = 'GET';
23			}
24
25			/**
26			* Testing middleware
27			*/
28			public function testMiddleware(): void
29			{
30			// setup
31			$route = '/route-with-middleware/';
32			$router = $this->getRouter();
33			$router->registerMiddleware('*', function () {
34			return [
35			1,
36			2
37			];
38			});
39			$router->addRoute($route, function (int $i, int $j) {
40			return [
41			$i,
42			$j
43			];
44			});
45			$router->registerMiddleware($route, function (int $i, int $j) {
46			return [
47			$i,
48			$j
49			];
50			});
51
52			// test body
53			/** @var array{0: int, 1: int} $result */
54			$result = $router->callRoute($route);
55
56			// assertions
57			$this->assertEquals(1, $result[0]);
58			$this->assertEquals(2, $result[1]);
59			}
60
61			/**
62			* Testing multiple middlewares
63			*/
64			public function testMultipleMiddlewaresInOrderAndOmitMalformed(): void
65			{
66			// setup
67			$route = '/route/[i:id]';
68			$router = $this->getRouter();
69
70			$router->addRoute($route, function (string $route, array $parameters): array {
71			return $parameters;
72			});
73
74			$router->registerMiddleware($route, /**
75			*
76			* @psalm-param string $route route
77			* @psalm-param array{id: int} $parameters parameters
78			*/
79			function (string $route, array $parameters) {
80			$parameters['_second'] = $parameters['id'];
81			$parameters['id'] += 9;
82
83			return [
84			$route,
85			$parameters
86			];
87			});
88
89			// This middleware is broken, don't parse the result
90			$router->registerMiddleware($route, function (string $route, array $parameters) {
91			$parameters['_dont_set_this'] = true;
92
93			return null;
94			});
95
96			$router->registerMiddleware($route, /**
97			*
98			* @psalm-param string $route
99			* route
100			* @psalm-param array{id: int} $parameters parameters
101			*/
102			function (string $route, array $parameters) {
103			$parameters['_third'] = $parameters['id'];
104			$parameters['id'] *= 2;
105
106			return [
107			$route,
108			$parameters
109			];
110			});
111
112			$router->registerMiddleware('', /*
113			*
114			* @psalm-param string $route
115			* route
116			* @psalm-param array{id: int} $parameters parameters
117			*/
118			function (string $route, array $parameters) {
119			$parameters['_first'] = $parameters['id'];
120			$parameters['id'] *= 2;
121
122			return [
123			$route,
124			$parameters
125			];
126			});
127
128			// test body
129			/** @var array<string, mixed> $result */
130			$result = $router->callRoute('/route/1');
131
132			// assertions
133			$this->assertEquals(22, $result['id']);
134			$this->assertEquals(1, $result['_first']);
135			$this->assertEquals(2, $result['_second']);
136			$this->assertEquals(11, $result['_third']);
137			$this->assertTrue(empty($result['_dont_set_this']));
138			}
139			}
140

alexdodonov / mezon-router

Push — master ( a4ddd3...82bd79 )

testMultipleMiddlewaresInOrderAndOmitMalformed() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like