Mezon\Router\StaticRoutes

Complexity

Total Complexity

10

Size/Duplication

Total Lines	108
Duplicated Lines	0 %

Importance

Changes	1
Bugs	1	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	findUniversalRouteProcessor()	0	9	2
A	getUniversalRouteProcessor()	0	10	2
A	getStaticRouteProcessor()	0	10	2
A	findStaticRouteProcessor()	0	9	2
A	getStaticRoutes()	0	9	2

<?php
declare(strict_types = 1);
namespace Mezon\Router;

/**
 * Trait StaticRoutes
 *
 * @package Router
 * @author Dodonov A.A.
 * @version v.1.0 (2021/09/27)
 * @copyright Copyright (c) 2021, aeon.org
 */
trait StaticRoutes
{

    /**
     * List of static routes for all supported request methods
     *
     * @var array<string, array<string, array{0: string, 1:string}|callable|string>>
     */
    protected $staticRoutes = [
        'GET' => [],
        'POST' => [],
        'PUT' => [],
        'DELETE' => [],
        'OPTION' => [],
        'PATCH' => []
    ];

    /**
     * Method returns static routes handlers for the specified request methods
     *
     * @param string $requestMethod
     *            request method
     * @return array<string, array{0: string, 1:string}|callable|string> handlers
     */
    protected function getStaticRoutes(string $requestMethod): array

The parameter $requestMethod is not used and could be removed.

    {
        $requestMethod = (string) $_SERVER['REQUEST_METHOD'];

        if (! isset($this->staticRoutes[$requestMethod])) {
            throw (new \Exception('Unsupported request method : ' . $requestMethod, - 1));
        }

        return $this->staticRoutes[$requestMethod];
    }

    /**
     * Method returns route handler
     *
     * @param string $route
     *            routes
     * @return array{0: string, 1: string}|callable|false|string route handler
     */
    protected function getStaticRouteProcessor(string $route)
    {
        $processors = $this->getStaticRoutes((string) $_SERVER['REQUEST_METHOD']);

        if (isset($processors[$route])) {
            $this->calledRoute = $route;

The property calledRoute does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return $processors[$route];
        } else {
            return false;
        }
    }

    /**
     * Method returns route handler
     *
     * @return array{0: string, 1: string}|callable|false|string route handler
     */
    protected function getUniversalRouteProcessor()
    {
        $processors = $this->getStaticRoutes((string) $_SERVER['REQUEST_METHOD']);

        if (isset($processors['*'])) {
            $this->calledRoute = '*';

The property calledRoute does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return $processors['*'];
        } else {
            return false;
        }
    }
    
    
    /**
     * Method searches route processor
     *
     * @param string $route
     *            route
     * @return mixed|false result of the router processor
     */
    public function findStaticRouteProcessor(string $route)
    {
        $processor = $this->getStaticRouteProcessor($route);
        
        if ($processor === false) {
            return false;
        }
        
        return $this->executeHandler($processor, $route);

It seems like executeHandler() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
    
    /**
     * Method searches universal route processor
     *
     * @param string $route
     *            route
     * @return mixed|false result of the router processor
     */
    public function findUniversalRouteProcessor(string $route)
    {
        $processor = $this->getUniversalRouteProcessor();
        
        if ($processor === false) {
            return false;
        }
        
        return $this->executeHandler($processor, $route);
    }
}