MiddlewareUnitTest::testMultipleMiddlewaresInOrderAndOmitMalformed() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/alexdo..." - alexdodonov/mezon-router - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 4cfdc5...37c7d0 )

by Alex

created 2021-10-12 06:06 UTC

testMultipleMiddlewaresInOrderAndOmitMalformed() A

↳ Parent: MiddlewareUnitTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	64
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
eloc	39
c	1
b	0
f	1
dl	0
loc	64
rs	9.296
cc	1
nc	1
nop	0

How to fix Long Method

<?php
namespace Mezon\Router\Tests\Simple;

use PHPUnit\Framework\TestCase;
use Mezon\Router\SimpleRouter;

/**
 *
 * @psalm-suppress PropertyNotSetInConstructor
 */
class MiddlewareUnitTest extends TestCase
{

    /**
     * Default setup
     *
     * {@inheritdoc}
     * @see \PHPUnit\Framework\TestCase::setUp()
     */
    public function setUp(): void
    {
        $_SERVER['REQUEST_METHOD'] = 'GET';
    }

    /**
     * Testing middleware
     */
    public function testMiddleware(): void
    {
        // setup
        $route = '/route-with-middleware/';
        $router = new SimpleRouter();
        $router->registerMiddleware('*', function () {
            return [
                1,
                2
            ];
        });
        $router->addRoute($route, function (int $i, int $j) {
            return [
                $i,
                $j
            ];
        });
        $router->registerMiddleware($route, function (int $i, int $j) {
            return [
                $i,
                $j
            ];
        });

        // test body
        $result = $router->callRoute($route);

        // assertions
        $this->assertEquals(1, $result[0]);
        $this->assertEquals(2, $result[1]);
    }

    /**
     * Testing multiple middlewares
     */
    public function testMultipleMiddlewaresInOrderAndOmitMalformed(): void
    {
        // setup
        $route = '/route/[i:id]';
        $router = new SimpleRouter();

        $router->addRoute($route, function (string $route, array $parameters): array {
            return $parameters;
        });

        $router->registerMiddleware(
            $route,
            function (string $route, array $parameters) {
                $parameters['_second'] = $parameters['id'];
                $parameters['id'] += 9;

                return [
                    $route,
                    $parameters
                ];
            });

        // This middleware is broken, don't parse the result
        $router->registerMiddleware(
            $route,
            function (string $route, array $parameters) {
                $parameters['_dont_set_this'] = true;

                return null;
            });

        $router->registerMiddleware(
            $route,
            function (string $route, array $parameters) {
                $parameters['_third'] = $parameters['id'];
                $parameters['id'] *= 2;

                return [
                    $route,
                    $parameters
                ];
            });

        $router->registerMiddleware(
            '*',
            function (string $route, array $parameters) {
                $parameters['_first'] = $parameters['id'];
                $parameters['id'] *= 2;

                return [
                    $route,
                    $parameters
                ];
            });

        // test body
        $result = $router->callRoute('/route/1');

        // assertions
        $this->assertEquals(22, $result['id']);
        $this->assertEquals(1, $result['_first']);
        $this->assertEquals(2, $result['_second']);
        $this->assertEquals(11, $result['_third']);
        $this->assertTrue(empty($result['_dont_set_this']));
    }
}


1			<?php
2			namespace Mezon\Router\Tests\Simple;
3
4			use PHPUnit\Framework\TestCase;
5			use Mezon\Router\SimpleRouter;
6
7			/**
8			*
9			* @psalm-suppress PropertyNotSetInConstructor
10			*/
11			class MiddlewareUnitTest extends TestCase
12			{
13
14			/**
15			* Default setup
16			*
17			* {@inheritdoc}
18			* @see \PHPUnit\Framework\TestCase::setUp()
19			*/
20			public function setUp(): void
21			{
22			$_SERVER['REQUEST_METHOD'] = 'GET';
23			}
24
25			/**
26			* Testing middleware
27			*/
28			public function testMiddleware(): void
29			{
30			// setup
31			$route = '/route-with-middleware/';
32			$router = new SimpleRouter();
33			$router->registerMiddleware('*', function () {
34			return [
35			1,
36			2
37			];
38			});
39			$router->addRoute($route, function (int $i, int $j) {
40			return [
41			$i,
42			$j
43			];
44			});
45			$router->registerMiddleware($route, function (int $i, int $j) {
46			return [
47			$i,
48			$j
49			];
50			});
51
52			// test body
53			$result = $router->callRoute($route);
54
55			// assertions
56			$this->assertEquals(1, $result[0]);
57			$this->assertEquals(2, $result[1]);
58			}
59
60			/**
61			* Testing multiple middlewares
62			*/
63			public function testMultipleMiddlewaresInOrderAndOmitMalformed(): void
64			{
65			// setup
66			$route = '/route/[i:id]';
67			$router = new SimpleRouter();
68
69			$router->addRoute($route, function (string $route, array $parameters): array {
70			return $parameters;
71			});
72
73			$router->registerMiddleware(
74			$route,
75			function (string $route, array $parameters) {
76			$parameters['_second'] = $parameters['id'];
77			$parameters['id'] += 9;
78
79			return [
80			$route,
81			$parameters
82			];
83			});
84
85			// This middleware is broken, don't parse the result
86			$router->registerMiddleware(
87			$route,
88			function (string $route, array $parameters) {
89			$parameters['_dont_set_this'] = true;
90
91			return null;
92			});
93
94			$router->registerMiddleware(
95			$route,
96			function (string $route, array $parameters) {
97			$parameters['_third'] = $parameters['id'];
98			$parameters['id'] *= 2;
99
100			return [
101			$route,
102			$parameters
103			];
104			});
105
106			$router->registerMiddleware(
107			'*',
108			function (string $route, array $parameters) {
109			$parameters['_first'] = $parameters['id'];
110			$parameters['id'] *= 2;
111
112			return [
113			$route,
114			$parameters
115			];
116			});
117
118			// test body
119			$result = $router->callRoute('/route/1');
120
121			// assertions
122			$this->assertEquals(22, $result['id']);
123			$this->assertEquals(1, $result['_first']);
124			$this->assertEquals(2, $result['_second']);
125			$this->assertEquals(11, $result['_third']);
126			$this->assertTrue(empty($result['_dont_set_this']));
127			}
128			}
129

alexdodonov / mezon-router

Push — master ( 4cfdc5...37c7d0 )

testMultipleMiddlewaresInOrderAndOmitMalformed() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like