alexdodonov / mezon-custom-client

Mezon/CustomClient/Tests/CurlWrapperUnitTest.php

<?php
namespace Mezon\CustomClient\Tests;

use PHPUnit\Framework\TestCase;
use Mezon\CustomClient\CurlWrapper;

/**
 *
 * @psalm-suppress PropertyNotSetInConstructor
 */
class CurlWrapperUnitTest extends TestCase
{

    /**
     * URL for testing purposes
     *
     * @var string
     */
    private $url = 'http://google.com';

    /**
     * Testing GET requests
     */
    public function testGetRequest(): void
    {
        // test body
        list ($body, $code) = CurlWrapper::sendRequest($this->url, [], 'GET');

        // assertions
        $this->assertStringContainsString('', $body, 'Invalid HTML was returned');

It seems like $body can also be of type true; however, parameter $haystack of PHPUnit\Framework\Assert::assertStringContainsString() does only seem to accept string, maybe add an additional type check?

        $this->assertEquals(301, $code, 'Invalid HTTP code');
    }

    /**
     * Testing POST requests
     */
    public function testPostRequest(): void
    {
        // test body
        list ($body, $code) = CurlWrapper::sendRequest($this->url, [], 'POST', [
            'data' => 1
        ]);

        // assertions
        $this->assertStringContainsString('', $body, 'Invalid HTML was returned');

It seems like $body can also be of type true; however, parameter $haystack of PHPUnit\Framework\Assert::assertStringContainsString() does only seem to accept string, maybe add an additional type check?

        $this->assertEquals(405, $code, 'Invalid HTTP code');
    }

    /**
     * Testing JSON request
     */
    public function testJsonRequest(): void
    {
        // test body
        list ($body, $code) = CurlWrapper::sendRequest($this->url, [
            'Content-type: application/json'
        ], 'POST', [
            'data' => 1
        ]);
        $body = json_decode($body, false);

The assignment to $body is dead and can be removed.

It seems like $body can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

        // assertions
        $this->assertEquals(405, $code);
    }
}