Debril\RssAtomBundle\Request\ModifiedSince

Complexity

Total Complexity

5

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getValue()	0	4	1
A	getModifiedSince()	0	13	3

<?php declare(strict_types=1);

namespace Debril\RssAtomBundle\Request;


use Psr\Log\LoggerInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;

class ModifiedSince
{

    const HTTP_HEADER_NAME = 'If-Modified-Since';

    private $value;

    private $logger;

    public function __construct(RequestStack $requestStack, LoggerInterface $logger)
    {
        $this->logger = $logger;
        $this->value = $this->getModifiedSince($requestStack->getCurrentRequest());

It seems like $requestStack->getCurrentRequest() can be null; however, getModifiedSince() does not accept null, maybe add an additional type check?

    }

    /**
     * @return \DateTime
     */
    public function getValue(): \DateTime
    {
        return $this->value;
    }

    private function getModifiedSince(Request $request):\DateTime
    {
        if ($request->headers->has(self::HTTP_HEADER_NAME)) {
            try {
                $string = $request->headers->get(self::HTTP_HEADER_NAME);
                return new \DateTime($string);
            } catch (\TypeError|\Exception $e) {
                $this->logger->notice(sprintf('If-Modified-Since Header has a unexpected value, exception was %s', $e->getMessage()));
            }
        }

        return new \DateTime('@1');
    }

}