NullResponse - Code Metrics - Inspection of "Fix #318 (#319)" - alexdebril/feed-io - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 01480a...d975fd )

by Alex

created 2021-01-20 17:48 UTC

NullResponse A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

60%

Importance

Changes

Metric	Value
wmc	7
lcom	0
cbo	0
dl	0
loc	60
ccs	6
cts	10
cp	0.6
rs	10
c	0
b	0
f	0

7 Methods

Rating	Name	Size	Complexity
A	getDuration()	4	1
A	getStatusCode()	4	1
A	getBody()	4	1
A	isModified()	4	1
A	getLastModified()	4	1
A	getHeaders()	4	1
A	getHeader()	4	1

<?php declare(strict_types=1);
/*
 * This file is part of the feed-io package.
 *
 * (c) Alexandre Debril <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FeedIo\Adapter;

/**
 * Null HTTP Response
 */
class NullResponse implements ResponseInterface
{

    /**
     * @return int
     */
    public function getDuration(): int
    {
        return 0;
    }

    /**
     * @return int
     */
    public function getStatusCode(): int
    {
        return 0;
    }

    /**
     * @return string
     */
    public function getBody() : ? string
    {
        return null;
    }

    /**
    * @return boolean
    */
    public function isModified() : bool
    {
        return true;
    }

    /**
     * @return \DateTime
     */
    public function getLastModified() : ?\DateTime
    {
        return new \DateTime('@0');
    }

    /**
     * @return iterable
     */
    public function getHeaders() : iterable
    {
        return [];
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @param  string       $name
     * @return iterable
     */
    public function getHeader(string $name) : iterable
    {
        return [];
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1		<?php declare(strict_types=1);
2		/*
3		* This file is part of the feed-io package.
4		*
5		* (c) Alexandre Debril <[email protected]>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10
11		namespace FeedIo\Adapter;
12
13		/**
14		* Null HTTP Response
15		*/
16		class NullResponse implements ResponseInterface
17		{
18
19		/**
20		* @return int
21		*/
22	1	public function getDuration(): int
23		{
24	1	return 0;
25		}
26
27		/**
28		* @return int
29		*/
30		public function getStatusCode(): int
31		{
32		return 0;
33		}
34
35		/**
36		* @return string
37		*/
38	2	public function getBody() : ? string
39		{
40	2	return null;
41		}
42
43		/**
44		* @return boolean
45		*/
46		public function isModified() : bool
47		{
48		return true;
49		}
50
51		/**
52		* @return \DateTime
53		*/
54		public function getLastModified() : ?\DateTime
55	1	{
56		return new \DateTime('@0');
57	1	}
58
59		/**
60		* @return iterable
61		*/
62		public function getHeaders() : iterable
63		{
64		return [];
		0 ignored issues – show Bug Best Practice introduced 2017-08-07 12:07 UTC by Report Bug Copy Issue Report The return type of `return array();` (`array`) is incompatible with the return type declared by the interface `FeedIo\Adapter\ResponseInterface::getHeaders` of type `FeedIo\Adapter\iterable`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
65		}
66
67		/**
68		* @param string $name
69		* @return iterable
70		*/
71		public function getHeader(string $name) : iterable
72		{
73		return [];
		0 ignored issues – show Bug Best Practice introduced 2017-08-07 12:07 UTC by Report Bug Copy Issue Report The return type of `return array();` (`array`) is incompatible with the return type declared by the interface `FeedIo\Adapter\ResponseInterface::getHeader` of type `FeedIo\Adapter\iterable`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
74		}
75		}
76

alexdebril / feed-io

Push — master ( 01480a...d975fd )

NullResponse A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

7 Methods

Duplication Side-by-Side

Filter issues like