1 | <?php declare(strict_types=1); |
||
17 | class Author extends RuleAbstract |
||
18 | { |
||
19 | const NODE_NAME = 'author'; |
||
20 | |||
21 | /** |
||
22 | * Sets the accurate $item property according to the DomElement content |
||
23 | * |
||
24 | * @param NodeInterface $node |
||
25 | * @param \DOMElement $element |
||
26 | * @return mixed |
||
27 | */ |
||
28 | 3 | public function setProperty(NodeInterface $node, \DOMElement $element) |
|
38 | |||
39 | /** |
||
40 | * Tells if the node contains the expected value |
||
41 | * |
||
42 | * @param NodeInterface $node |
||
43 | * @return bool |
||
44 | */ |
||
45 | 4 | protected function hasValue(NodeInterface $node) : bool |
|
49 | |||
50 | /** |
||
51 | * Creates and adds the element(s) to the docuement's rootElement |
||
52 | * |
||
53 | * @param \DomDocument $document |
||
54 | * @param \DOMElement $rootElement |
||
55 | * @param NodeInterface $node |
||
56 | */ |
||
57 | 1 | protected function addElement(\DomDocument $document, \DOMElement $rootElement, NodeInterface $node) : void |
|
61 | } |
||
62 |
Let’s take a look at an example:
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.
Available Fixes
Change the type-hint for the parameter:
Add an additional type-check:
Add the method to the interface: