CheckCommand::execute() - Code Metrics - Inspection of "CheckCommand" - alexdebril/feed-io - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — issue/270 ( cf7824 )

by Alex

created 2020-03-26 20:02 UTC

CheckCommand::execute() B

↳ Parent: CheckCommand

Complexity

Conditions	6
Paths	32

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes

Metric	Value
dl	0
loc	60
ccs	0
cts	44
cp	0
rs	8.2505
c	0
b	0
f	0
cc	6
nc	32
nop	2
crap	42

How to fix Long Method

<?php declare(strict_types=1);
/*
 * This file is part of the feed-io package.
 *
 * (c) Alexandre Debril <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FeedIo\Command;

use FeedIo\Command\Check\CheckerAbstract;
use FeedIo\Command\Check\CountChecker;
use FeedIo\Command\Check\HistoryChecker;
use FeedIo\Factory;
use FeedIo\Feed\ItemInterface;
use FeedIo\FeedInterface;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Formatter\OutputFormatterStyle;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

class CheckCommand extends Command
{
    protected function configure()
    {
        $this->setName('check')
            ->setDescription('checks if a feed gets correctly updated')
            ->addArgument(
                'url',
                InputArgument::REQUIRED,
                'Please provide the feed\' URL'
            )
        ;
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $this->configureOutput($output);
        $url = $input->getArgument('url');

        $feedIo = Factory::create()->getFeedIo();
        $feed = $feedIo->read($url)->getFeed();
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $output->writeln("<info>first access to {$feed->getTitle()}</info>");

        $failures = 0;

        $count = count($feed);
        if( $count == 0) {
            $failures++;
            $output->writeln("<error>empty feed</error>");
        }

        $output->writeln("<info>found {$count} items</info>");

        $lastModifiedDates = [];
        /** @var \FeedIo\Feed\ItemInterface $item */
        foreach ($feed as $i => $item) {
            $lastModifiedDates[] = $item->getLastModified();
        }

        sort($lastModifiedDates);

        $first = current($lastModifiedDates);

        /** @var \DateTime $last */
        $last = end($lastModifiedDates);

        $normalDateFlow = true;
        if ($last > $first) {
            $output->writeln("<info>first item was published on {$first->format(\DateTime::ATOM)}</info>");
            $output->writeln("<info>last item was published on {$last->format(\DateTime::ATOM)}</info>");
        } else {
            $output->writeln("<warn>All items have the same date</warn>");
            $normalDateFlow = false;
        }

        if ($normalDateFlow) {
            $pick = intval($count / 2);
            $lastModified = $lastModifiedDates[$pick];
        } else {
            $lastModified = $last->sub(new \DateInterval('-1 days'));
        }

        $secondHit = $feedIo->readSince($url, $lastModified)->getFeed();
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $count = count($secondHit);
        if( $count == 0) {
            $failures++;
            $output->writeln("<error>empty feed</error>");
        }

        $output->writeln("<info>found {$count} items</info>");
        return $failures;
    }

    private function configureOutput(OutputInterface $output): void
    {
        $outputStyle = new OutputFormatterStyle('black', 'magenta', ['bold']);
        $output->getFormatter()->setStyle('warn', $outputStyle);
    }

}


1			<?php declare(strict_types=1);
2			/*
3			* This file is part of the feed-io package.
4			*
5			* (c) Alexandre Debril <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace FeedIo\Command;
12
13			use FeedIo\Command\Check\CheckerAbstract;
14			use FeedIo\Command\Check\CountChecker;
15			use FeedIo\Command\Check\HistoryChecker;
16			use FeedIo\Factory;
17			use FeedIo\Feed\ItemInterface;
18			use FeedIo\FeedInterface;
19			use Symfony\Component\Console\Command\Command;
20			use Symfony\Component\Console\Formatter\OutputFormatterStyle;
21			use Symfony\Component\Console\Input\InputArgument;
22			use Symfony\Component\Console\Input\InputInterface;
23			use Symfony\Component\Console\Input\InputOption;
24			use Symfony\Component\Console\Output\OutputInterface;
25
26			class CheckCommand extends Command
27			{
28			protected function configure()
29			{
30			$this->setName('check')
31			->setDescription('checks if a feed gets correctly updated')
32			->addArgument(
33			'url',
34			InputArgument::REQUIRED,
35			'Please provide the feed\' URL'
36			)
37			;
38			}
39
40			protected function execute(InputInterface $input, OutputInterface $output)
41			{
42			$this->configureOutput($output);
43			$url = $input->getArgument('url');
44
45			$feedIo = Factory::create()->getFeedIo();
46			$feed = $feedIo->read($url)->getFeed();
			0 ignored issues – show Bug introduced 2020-03-26 20:04 UTC by Report Bug Copy Issue Report It seems like `$url` defined by `$input->getArgument('url')` on line `43` can also be of type `array<integer,string>` or `null`; however, `FeedIo\FeedIo::read()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
47
48			$output->writeln("<info>first access to {$feed->getTitle()}</info>");
49
50			$failures = 0;
51
52			$count = count($feed);
53			if( $count == 0) {
54			$failures++;
55			$output->writeln("<error>empty feed</error>");
56			}
57
58			$output->writeln("<info>found {$count} items</info>");
59
60			$lastModifiedDates = [];
61			/** @var \FeedIo\Feed\ItemInterface $item */
62			foreach ($feed as $i => $item) {
63			$lastModifiedDates[] = $item->getLastModified();
64			}
65
66			sort($lastModifiedDates);
67
68			$first = current($lastModifiedDates);
69
70			/** @var \DateTime $last */
71			$last = end($lastModifiedDates);
72
73			$normalDateFlow = true;
74			if ($last > $first) {
75			$output->writeln("<info>first item was published on {$first->format(\DateTime::ATOM)}</info>");
76			$output->writeln("<info>last item was published on {$last->format(\DateTime::ATOM)}</info>");
77			} else {
78			$output->writeln("<warn>All items have the same date</warn>");
79			$normalDateFlow = false;
80			}
81
82			if ($normalDateFlow) {
83			$pick = intval($count / 2);
84			$lastModified = $lastModifiedDates[$pick];
85			} else {
86			$lastModified = $last->sub(new \DateInterval('-1 days'));
87			}
88
89			$secondHit = $feedIo->readSince($url, $lastModified)->getFeed();
			0 ignored issues – show Bug introduced 2020-03-26 20:04 UTC by Report Bug Copy Issue Report It seems like `$url` defined by `$input->getArgument('url')` on line `43` can also be of type `array<integer,string>` or `null`; however, `FeedIo\FeedIo::readSince()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
90
91			$count = count($secondHit);
92			if( $count == 0) {
93			$failures++;
94			$output->writeln("<error>empty feed</error>");
95			}
96
97			$output->writeln("<info>found {$count} items</info>");
98			return $failures;
99			}
100
101			private function configureOutput(OutputInterface $output): void
102			{
103			$outputStyle = new OutputFormatterStyle('black', 'magenta', ['bold']);
104			$output->getFormatter()->setStyle('warn', $outputStyle);
105			}
106
107			}
108

alexdebril / feed-io

Push — issue/270 ( cf7824 )

CheckCommand::execute() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like