FeedIo\Parser\UrlGenerator

Complexity

Total Complexity

5

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getAbsolutePath()	0	7	3
A	generateAbsolutePath()	0	5	2

<?php declare(strict_types=1);
/*
 * This file is part of the feed-io package.
 *
 * (c) Alexandre Debril <alex.debril@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FeedIo\Parser;

class UrlGenerator
{

    /**
     * @param string $host
     * @param string $path
     * @return string
     */
    public function getAbsolutePath(string $path, string $host = null): string
    {
        if (! parse_url($path, PHP_URL_HOST) && $host) {

The expression $host of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            return $this->generateAbsolutePath($host, $path);
        }
        return $path;
    }

    /**
     * @param string $host
     * @param string $path
     * @return string
     */
    public function generateAbsolutePath(string $host, string $path): string
    {
        $path = substr($path, 0, 1) == '/' ? $path:"/{$path}";
        return $host . $path;
    }
}