DiscoverCommand::execute() - Code Metrics - alexdebril/feed-io - Measure and Improve Code Quality continuously with Scrutinizer

DiscoverCommand::execute() A
last analyzed 2021-03-01 18:10 UTC

↳ Parent: DiscoverCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.8333
c	0
b	0
f	0
cc	2
nc	2
nop	2

<?php declare(strict_types=1);
/*
 * This file is part of the feed-io package.
 *
 * (c) Alexandre Debril <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FeedIo\Command;

use FeedIo\Factory;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Class DiscoverCommand
 * @codeCoverageIgnore
 */
class DiscoverCommand extends Command
{
    protected function configure()
    {
        $this->setName('discover')
            ->setDescription('discovers feeds inside a web page')
            ->addArgument(
                'url',
                InputArgument::REQUIRED,
                'Please provide the URL'
            )
        ;
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $url = $input->getArgument('url');
        $output->writeln("<info>Discovering feeds from {$url}</info>");
        $feedIo = Factory::create()->getFeedIo();
        $feeds = $feedIo->discover($url);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        foreach ($feeds as $feed) {
            $output->writeln("<info>found : {$feed}</info>");
        }

        return 0;
    }
}


1			<?php declare(strict_types=1);
2			/*
3			* This file is part of the feed-io package.
4			*
5			* (c) Alexandre Debril <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace FeedIo\Command;
12
13			use FeedIo\Factory;
14			use Symfony\Component\Console\Command\Command;
15			use Symfony\Component\Console\Input\InputArgument;
16			use Symfony\Component\Console\Input\InputInterface;
17			use Symfony\Component\Console\Input\InputOption;
18			use Symfony\Component\Console\Output\OutputInterface;
19
20			/**
21			* Class DiscoverCommand
22			* @codeCoverageIgnore
23			*/
24			class DiscoverCommand extends Command
25			{
26			protected function configure()
27			{
28			$this->setName('discover')
29			->setDescription('discovers feeds inside a web page')
30			->addArgument(
31			'url',
32			InputArgument::REQUIRED,
33			'Please provide the URL'
34			)
35			;
36			}
37
38			protected function execute(InputInterface $input, OutputInterface $output)
39			{
40			$url = $input->getArgument('url');
41			$output->writeln("<info>Discovering feeds from {$url}</info>");
42			$feedIo = Factory::create()->getFeedIo();
43			$feeds = $feedIo->discover($url);
			0 ignored issues – show Bug introduced 2019-02-12 17:27 UTC by Report Bug Copy Issue Report It seems like `$url` defined by `$input->getArgument('url')` on line `40` can also be of type `array<integer,string>` or `null`; however, `FeedIo\FeedIo::discover()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
44
45			foreach ($feeds as $feed) {
46			$output->writeln("<info>found : {$feed}</info>");
47			}
48
49			return 0;
50			}
51			}
52

alexdebril / feed-io

DiscoverCommand::execute() A last analyzed 2021-03-01 18:10 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

DiscoverCommand::execute() A
last analyzed 2021-03-01 18:10 UTC