CalculatorApiController - Code Metrics - Inspection of "error calculadora i api tipus de dades arreclat +..." - alexbonavila/LaravelMarketInformation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 91fe5a...ca5114 )

by Alex

created 2016-06-12 17:50 UTC

CalculatorApiController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	104
Duplicated Lines	7.69 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	7
Bugs	0	Features	0

Metric	Value
wmc	13
c	7
b	0
f	0
lcom	1
cbo	5
dl	8
loc	104
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	1
B	store()	0	30	2
A	getUserCalculs()	8	8	1
B	dataVerify()	0	12	9

How to fix Duplicated Code

<?php

namespace App\Http\Controllers;

use App\Http\Transformers\CalculatorTransformer;
use App\SimulatorHistory;
use App\User;
use Chrisbjr\ApiGuard\Http\Controllers\ApiGuardController;
use DB;
use Illuminate\Http\Request;
use App\Http\Requests;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Input;
use Vinkla\Alert\Alert;

/**
 * Class CalculatorApiController
 * @package App\Http\Controllers
 */
class CalculatorApiController extends ApiGuardController
{

    /**
     * @var CalculatorTransformer
     */
    protected $calcul_transformer;

    /**
     * @var SimulatorHistory
     */
    protected $calculator;

    protected $alert;
    /**
     * @var array
     */
    protected $apiMethods = [
        'store' => [
            'keyAuthentication' => true
        ],
        'getUserCalculs' => [
            'keyAuthentication' => true
        ]
    ];

    /**
     * CalculatorController constructor.
     * @param CalculatorTransformer $calcul_transformer
     * @param User $user
     * @param SimulatorHistory $calculator
     */
    public function __construct(Alert $alert,CalculatorTransformer $calcul_transformer, User $user, SimulatorHistory $calculator)
    {
        parent::__construct();


        $this->calcul_transformer = $calcul_transformer;
        $this->user = $user;
        $this->calculator = $calculator;
        $this->alert=$alert;
    }

    /**
     *Store calculator data in DB
     * @param Request $request
     * @return mixed
     */
    public function store(Request $request)
    {
        $user = Auth::user();


        if ($this->dataVerify($request)) {
            $calcul = array(
                'user_id' => $user->id,
                'name' => $request->input('name'),
                'quantity_to_buy' => $request->input('quantity_to_buy'),
                'quote_to_buy' => $request->input('quote_to_buy'),
                'price_to_buy' => $request->input('price_to_buy'),
                'quantity_to_sell' => $request->input('quantity_to_sell'),
                'quote_to_sell' => $request->input('quote_to_sell'),
                'tax_percent_to_discount' => $request->input('tax_percent_to_discount'),
                'price_to_sell' => $request->input('price_to_sell'),
                'gains_or_losses' => $request->input('gains_or_losses'),
            );


            $this->alert->success('El calcul ha estat guardat');


            $this->calculator->create($calcul);

            return $this->response->withItem($calcul, $this->calcul_transformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return "Error desconegut";
    }

    /**
     * @return array|static[]
     */
    public function getUserCalculs()

    {
        $user = Auth::user();

        $data = DB::table('simulator_history')->where('user_id', '=', $user->id)->get();

        return $data;
    }

    public function dataVerify(Request $request)
    {
        if (is_numeric($request->input('quantity_to_buy')) && is_numeric($request->input('quote_to_buy')) && is_numeric($request->input('price_to_buy')) &&
            is_numeric($request->input('quantity_to_sell')) && is_numeric($request->input('quote_to_sell')) && is_numeric($request->input('tax_percent_to_discount')) &&
            is_numeric($request->input('price_to_sell')) && is_numeric($request->input('gains_or_losses'))
        ) {
            return true;
        } else {
            dd("Les dades son errones");
            return false;
        }
    }
}


1		<?php
2
3		namespace App\Http\Controllers;
4
5		use App\Http\Transformers\CalculatorTransformer;
6		use App\SimulatorHistory;
7		use App\User;
8		use Chrisbjr\ApiGuard\Http\Controllers\ApiGuardController;
9		use DB;
10		use Illuminate\Http\Request;
11		use App\Http\Requests;
12		use Illuminate\Support\Facades\Auth;
13		use Illuminate\Support\Facades\Input;
14		use Vinkla\Alert\Alert;
15
16		/**
17		* Class CalculatorApiController
18		* @package App\Http\Controllers
19		*/
20		class CalculatorApiController extends ApiGuardController
21		{
22
23		/**
24		* @var CalculatorTransformer
25		*/
26		protected $calcul_transformer;
27
28		/**
29		* @var SimulatorHistory
30		*/
31		protected $calculator;
32
33		protected $alert;
34		/**
35		* @var array
36		*/
37		protected $apiMethods = [
38		'store' => [
39		'keyAuthentication' => true
40		],
41		'getUserCalculs' => [
42		'keyAuthentication' => true
43		]
44		];
45
46		/**
47		* CalculatorController constructor.
48		* @param CalculatorTransformer $calcul_transformer
49		* @param User $user
50		* @param SimulatorHistory $calculator
51		*/
52		public function __construct(Alert $alert,CalculatorTransformer $calcul_transformer, User $user, SimulatorHistory $calculator)
53		{
54		parent::__construct();
55
56
57		$this->calcul_transformer = $calcul_transformer;
58		$this->user = $user;
59		$this->calculator = $calculator;
60		$this->alert=$alert;
61		}
62
63		/**
64		*Store calculator data in DB
65		* @param Request $request
66		* @return mixed
67		*/
68		public function store(Request $request)
69		{
70		$user = Auth::user();
71
72
73		if ($this->dataVerify($request)) {
74		$calcul = array(
75		'user_id' => $user->id,
76		'name' => $request->input('name'),
77		'quantity_to_buy' => $request->input('quantity_to_buy'),
78		'quote_to_buy' => $request->input('quote_to_buy'),
79		'price_to_buy' => $request->input('price_to_buy'),
80		'quantity_to_sell' => $request->input('quantity_to_sell'),
81		'quote_to_sell' => $request->input('quote_to_sell'),
82		'tax_percent_to_discount' => $request->input('tax_percent_to_discount'),
83		'price_to_sell' => $request->input('price_to_sell'),
84		'gains_or_losses' => $request->input('gains_or_losses'),
85		);
86
87
88		$this->alert->success('El calcul ha estat guardat');
89
90
91		$this->calculator->create($calcul);
92
93		return $this->response->withItem($calcul, $this->calcul_transformer);
		0 ignored issues – show Documentation introduced 2016-05-27 18:54 UTC by Report Bug Copy Issue Report `$this->calcul_transformer` is of type `object<App\Http\Transfor...\CalculatorTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
94		}
95
96		return "Error desconegut";
97		}
98
99		/**
100		* @return array\|static[]
101		*/
102	View Code Duplication	public function getUserCalculs()
		0 ignored issues – show Duplication introduced 2016-06-05 21:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
103		{
104		$user = Auth::user();
105
106		$data = DB::table('simulator_history')->where('user_id', '=', $user->id)->get();
107
108		return $data;
109		}
110
111		public function dataVerify(Request $request)
112		{
113		if (is_numeric($request->input('quantity_to_buy')) && is_numeric($request->input('quote_to_buy')) && is_numeric($request->input('price_to_buy')) &&
114		is_numeric($request->input('quantity_to_sell')) && is_numeric($request->input('quote_to_sell')) && is_numeric($request->input('tax_percent_to_discount')) &&
115		is_numeric($request->input('price_to_sell')) && is_numeric($request->input('gains_or_losses'))
116		) {
117		return true;
118		} else {
119		dd("Les dades son errones");
120		return false;
121		}
122		}
123		}
124

alexbonavila / LaravelMarketInformation

Push — master ( 91fe5a...ca5114 )

CalculatorApiController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like