App\Http\Controllers\ExchangeHistoryTableFeeder

Complexity

Total Complexity

4

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getSymbolsFormDB()	0	15	2
A	httpCall()	0	8	1
A	storeDataInDB()	0	17	1

<?php

namespace App\Http\Controllers;

use App\InteractionMethodsMOD\GetMethods;
use Carbon\Carbon;
use DB;
use Illuminate\Http\Request;

use GuzzleHttp\Client;

use App\Http\Requests;

/**
 * Class ExchangeHistoryTableFeeder
 * @package App\Http\Controllers
 */
class ExchangeHistoryTableFeeder extends Controller
{

    /**
     *Elimina les dades antigues i n'insereix unes de noves
     */
    public function getSymbolsFormDB()
    {
        DB::table('exchange_history')->truncate();

        $symbols = DB::table('companies')->select('symbol')->get();

        for($i=0; $i<count($symbols); $i++)

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

        {
            $symbol=$symbols[$i]->symbol;
            $gm = new GetMethods();
            $this->httpCall($gm,$symbol);

        }

    }

    /**
     * Aconegueix les dades de la api i fa la crida de la funció que les guardara a la BD
     *
     * @param GetMethods $interaction_methods
     * @param $symbol
     */
    public function httpCall(GetMethods $interaction_methods, $symbol)
    {
        $glz_cli=new Client();

        $data = $interaction_methods->interactiveChart($glz_cli,$symbol);

        $this->storeDataInDB($data);
    }

    /**
     *
     * Persisteix les dades al MYSQL
     *
     * @param $data
     */
    public function storeDataInDB($data)
    {
        DB::table('exchange_history')->insert([
            [
                'symbol' => $data->Elements[0]->Symbol,
                'positions' => json_encode($data->Positions),
                'dates' => json_encode($data->Dates),
                'values' => json_encode($data->Elements[0]->DataSeries->close->values),
                'max_date' =>  $data->Elements[0]->DataSeries->close->maxDate,
                'min_date' => $data->Elements[0]->DataSeries->close->minDate,
                'min_value' => $data->Elements[0]->DataSeries->close->min,
                'max_value' =>  $data->Elements[0]->DataSeries->close->max,
                'created_at' => Carbon::now()->toDateTimeString(),
                'updated_at' => Carbon::now()->toDateTimeString()
            ]
        ]);
    }
}