CompanyFollowTableFeeder::handle() - Code Metrics - Inspection of "Codi refactoritzat segit (SOLID i injecció de depe..." - alexbonavila/LaravelMarketInformation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 04c9ff...5dea00 )

by Alex

created 2016-05-31 15:01 UTC

CompanyFollowTableFeeder::handle() A

↳ Parent: CompanyFollowTableFeeder

Complexity

Conditions	3
Paths	6

Size

Total Lines	20
Code Lines	11

Duplication

Lines	20
Ratio	100 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	20
loc	20
rs	9.4285
cc	3
eloc	11
nc	6
nop	0

<?php

namespace App\Console\Commands;

use App\Console\AuxiliaryClasses\DataBaseFunctions;
use App\Console\AuxiliaryClasses\HttpCalls;
use App\Console\AuxiliaryClasses\ProgressControl;
use Illuminate\Console\Command;
use Symfony\Component\Config\Definition\Exception\Exception;

/**
 * Class CompanyFollowTableFeeder
 * @package App\Console\Commands
 */
class CompanyFollowTableFeeder extends Command

{

    /**
     * @var DataBaseFunctions
     */
    protected $db_functions;

    /**
     * @var HttpCalls
     */
    protected $http_calls;

    /**
     * @var ProgressControl
     */
    protected $progress_control;

    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'company_follow:feed';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Feed the table companies_follow from DB';

    /**
     * Create a new command instance.
     * @param DataBaseFunctions $db_functions
     * @param HttpCalls $http_calls
     * @param ProgressControl $progress_control
     */
    public function __construct(DataBaseFunctions $db_functions,HttpCalls $http_calls,ProgressControl $progress_control)
    {
        parent::__construct();

        $this->db_functions=$db_functions;
        $this->http_calls=$http_calls;
        $this->progress_control=$progress_control;

    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $table='company_follow';

        $symbols=$this->db_functions->truncateBDValuesAndGetNew($table);

        for($i=0; $i<count($symbols); $i++){
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            try{

                $symbol=$symbols[$i]->symbol;
                $data=$this->http_calls->getTableFollow($symbol);
                $this->db_functions->storeCompanyFollowTable($data,$table);
                $this->progress_control->progressControl($i);

            }catch(Exception $e){


            }
        }
        echo("100% Table company_follow fed\n");
    }
}


1		<?php
2
3		namespace App\Console\Commands;
4
5		use App\Console\AuxiliaryClasses\DataBaseFunctions;
6		use App\Console\AuxiliaryClasses\HttpCalls;
7		use App\Console\AuxiliaryClasses\ProgressControl;
8		use Illuminate\Console\Command;
9		use Symfony\Component\Config\Definition\Exception\Exception;
10
11		/**
12		* Class CompanyFollowTableFeeder
13		* @package App\Console\Commands
14		*/
15	View Code Duplication	class CompanyFollowTableFeeder extends Command
		0 ignored issues – show Duplication introduced 2016-05-31 15:05 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16		{
17
18		/**
19		* @var DataBaseFunctions
20		*/
21		protected $db_functions;
22
23		/**
24		* @var HttpCalls
25		*/
26		protected $http_calls;
27
28		/**
29		* @var ProgressControl
30		*/
31		protected $progress_control;
32
33		/**
34		* The name and signature of the console command.
35		*
36		* @var string
37		*/
38		protected $signature = 'company_follow:feed';
39
40		/**
41		* The console command description.
42		*
43		* @var string
44		*/
45		protected $description = 'Feed the table companies_follow from DB';
46
47		/**
48		* Create a new command instance.
49		* @param DataBaseFunctions $db_functions
50		* @param HttpCalls $http_calls
51		* @param ProgressControl $progress_control
52		*/
53		public function __construct(DataBaseFunctions $db_functions,HttpCalls $http_calls,ProgressControl $progress_control)
54		{
55		parent::__construct();
56
57		$this->db_functions=$db_functions;
58		$this->http_calls=$http_calls;
59		$this->progress_control=$progress_control;
60
61		}
62
63		/**
64		* Execute the console command.
65		*
66		* @return mixed
67		*/
68		public function handle()
69		{
70		$table='company_follow';
71
72		$symbols=$this->db_functions->truncateBDValuesAndGetNew($table);
73
74		for($i=0; $i<count($symbols); $i++){
		0 ignored issues – show Performance Best Practice introduced 2016-05-31 15:05 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
75		try{
76
77		$symbol=$symbols[$i]->symbol;
78		$data=$this->http_calls->getTableFollow($symbol);
79		$this->db_functions->storeCompanyFollowTable($data,$table);
80		$this->progress_control->progressControl($i);
81
82		}catch(Exception $e){
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-31 15:05 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
83
84		}
85		}
86		echo("100% Table company_follow fed\n");
87		}
88		}
89

alexbonavila / LaravelMarketInformation

Push — master ( 04c9ff...5dea00 )

CompanyFollowTableFeeder::handle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like