App\Console\AuxiliaryClasses\HttpCalls

Complexity

Total Complexity

7

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getTableFollow()	0	8	1
A	getExchangeHistory()	0	8	1
A	getCompanies()	0	10	1
A	discardRepeated()	0	13	3

<?php
/**
 * Created by PhpStorm.
 * User: alumne
 * Date: 31/05/16
 * Time: 14:04
 */

namespace App\Console\AuxiliaryClasses;

use App\InteractionMethodsMOD\GetMethods;

/**
 * Class HttpCalls
 * @package App\Console\AuxiliaryClasses
 */
class HttpCalls
{
    /**
     * @var GetMethods
     */
    protected $get_methods;

    /**
     * HttpCalls constructor.
     * @param GetMethods $get_methods
     */
    public function __construct(GetMethods $get_methods)
    {
        $this->get_methods=$get_methods;
    }

    /**
     * @param $symbol
     * @return mixed|\Psr\Http\Message\ResponseInterface
     */
    public function getTableFollow($symbol)
    {
        $data=$this->get_methods->stockQuote($symbol);

        sleep(4);

        return $data;
    }

    public function getExchangeHistory($symbol)
    {
        $data=$this->get_methods->interactiveChart($symbol);

        sleep(4);

        return $data;
    }

    public function getCompanies($symbol)
    {
        $data=$this->get_methods->companyLookup($symbol);

        $data=$this->discardRepeated($data,$symbol);

        sleep(4);

        return $data;
    }

    /**
     * @param $data
     * @param $symbol
     * @return $node

The doc-type $node could not be parsed: Unknown type name "$node" at position 0. (view supported doc-types)

     * @return null
     */
    private function discardRepeated($data, $symbol)
    {
        for($i=0;$i<count($data);$i++){

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $symbol_to_compare=(string) $data[$i]->Symbol;

            if($symbol_to_compare==$symbol){
                return $node=$data[$i];

$node is not used, you could remove the assignment.

            }

        }
        return null;
    }


}