AHJ\ApprovalTests\ReceivedMap::create()

Complexity

Conditions	7
Paths	25

Size

Total Lines	29
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	7

Importance

Changes

0

<?php
    public function create(array $input, array $output): string
    {
        $received = [];

        foreach ($input as $inputKey => $inputValue) {
            if ('array' === gettype($inputValue)) {
                $received[$inputKey] = '[';
                $received[$inputKey] .= implode(', ', $inputValue);
                $received[$inputKey] .= '] -> ';
            }
            // TODO: make sure this works for objects which do not have a __toString method
            if ('object' === gettype($inputValue)) {
                $received[$inputKey] = '[' . $inputValue . '] -> ';

Are you sure $inputValue of type object can be used in concatenation?

            }
        }

        foreach ($output as $outputKey => $outputValue) {
            if ('array' === gettype($outputValue)) {
                $received[$outputKey] = $received[$outputKey] . '[';
                $received[$outputKey] .= implode(', ', $outputValue);
                $received[$outputKey] .= ']';
            }

            if ('object' === gettype($outputValue)) {
                $received[$outputKey] = $received[$outputKey] . '[' . $outputValue . ']';

Are you sure $outputValue of type object can be used in concatenation?

            }
        }

        return implode("\n", $received);
    }