Issues in Acl.php (master) - Issues in master - alexander-torosh/yona-cms - Measure and Improve Code Quality continuously with Scrutinizer

Issues (336)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/plugins/Acl.php (3 issues)

Labels

Bug 3

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * DefaultAcl
 * @copyright Copyright (c) 2011 - 2015 Aleksandr Torosh (http://wezoom.com.ua)
 * @author Aleksandr Torosh <[email protected]>
 */

namespace YonaCMS\Plugin;

use Phalcon\Mvc\Dispatcher,
    Phalcon\Mvc\User\Plugin,
    Phalcon\Mvc\View,
    Application\Acl\DefaultAcl;

class Acl extends Plugin
{

    public function __construct(DefaultAcl $acl, Dispatcher $dispatcher, View $view)
    {
        $role = $this->getRole();

        $module = $dispatcher->getModuleName();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $controller = $dispatcher->getControllerName();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $action = $dispatcher->getActionName();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $resourceKey = $module . '/' . $controller;
        $resourceVal = $action;

        if ($acl->isResource($resourceKey)) {
            if (!$acl->isAllowed($role, $resourceKey, $resourceVal)) {
                $this->accessDenied($role, $resourceKey, $resourceVal, $view);
            }
        } else {
            $this->resourceNotFound($resourceKey, $view);
        }

    }

    private function getRole()
    {
        $auth = $this->session->get('auth');
        if (!$auth) {
            $role = 'guest';
        } else {
            if ($auth->admin_session == true) {
                $role = \Admin\Model\AdminUser::getRoleById($auth->id);
            } else {
                $role = 'member';
            }
        }
        return $role;

    }

    private function accessDenied($role, $resourceKey = null, $resourceVal = null, View $view)
    {
        if (in_array($role, ['guest', 'member'])) {
            return $this->redirect('/admin');
        }

        $view->setViewsDir(__DIR__ . '/../modules/Index/views/');
        $view->setPartialsDir('');
        $view->message = "$role - Access Denied to resource <b>$resourceKey::$resourceVal</b>";
        $view->partial('error/error403');

        $response = new \Phalcon\Http\Response();
        $response->setHeader(403, 'Forbidden');
        $response->sendHeaders();
        echo $response->getContent();
        exit;
    }

    private function resourceNotFound($resourceKey, View $view)
    {
        $view->setViewsDir(__DIR__ . '/../modules/Index/views/');
        $view->setPartialsDir('');
        $view->message = "Acl resource <b>$resourceKey</b> in <b>/app/config/acl.php</b> not exists";
        $view->partial('error/error404');
        $response = new \Phalcon\Http\Response();
        $response->setHeader(404, 'Not Found');
        $response->sendHeaders();
        echo $response->getContent();
        exit;
    }

    private function redirect($url, $code = 302)
    {
        switch ($code) {
            case 301 :
                header('HTTP/1.1 301 Moved Permanently');
                break;
            case 302 :
                header('HTTP/1.1 302 Moved Temporarily');
                break;
        }
        header('Location: ' . $url);
        exit;
    }

}

1		<?php
2
3		/**
4		* DefaultAcl
5		* @copyright Copyright (c) 2011 - 2015 Aleksandr Torosh (http://wezoom.com.ua)
6		* @author Aleksandr Torosh <[email protected]>
7		*/
8
9		namespace YonaCMS\Plugin;
10
11		use Phalcon\Mvc\Dispatcher,
12		Phalcon\Mvc\User\Plugin,
13		Phalcon\Mvc\View,
14		Application\Acl\DefaultAcl;
15
16		class Acl extends Plugin
17		{
18
19		public function __construct(DefaultAcl $acl, Dispatcher $dispatcher, View $view)
20		{
21		$role = $this->getRole();
22
23		$module = $dispatcher->getModuleName();
		0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$module` is correct as `$dispatcher->getModuleName()` (which targets `Phalcon\Dispatcher::getModuleName()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
24		$controller = $dispatcher->getControllerName();
		0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$controller` is correct as `$dispatcher->getControllerName()` (which targets `Phalcon\Mvc\Dispatcher::getControllerName()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
25		$action = $dispatcher->getActionName();
		0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$action` is correct as `$dispatcher->getActionName()` (which targets `Phalcon\Dispatcher::getActionName()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
26
27		$resourceKey = $module . '/' . $controller;
28		$resourceVal = $action;
29
30		if ($acl->isResource($resourceKey)) {
31		if (!$acl->isAllowed($role, $resourceKey, $resourceVal)) {
32		$this->accessDenied($role, $resourceKey, $resourceVal, $view);
33		}
34		} else {
35		$this->resourceNotFound($resourceKey, $view);
36		}
37
38		}
39
40		private function getRole()
41		{
42		$auth = $this->session->get('auth');
43		if (!$auth) {
44		$role = 'guest';
45		} else {
46		if ($auth->admin_session == true) {
47		$role = \Admin\Model\AdminUser::getRoleById($auth->id);
48		} else {
49		$role = 'member';
50		}
51		}
52		return $role;
53
54		}
55
56		private function accessDenied($role, $resourceKey = null, $resourceVal = null, View $view)
57		{
58		if (in_array($role, ['guest', 'member'])) {
59		return $this->redirect('/admin');
60		}
61
62		$view->setViewsDir(__DIR__ . '/../modules/Index/views/');
63		$view->setPartialsDir('');
64		$view->message = "$role - Access Denied to resource <b>$resourceKey::$resourceVal</b>";
65		$view->partial('error/error403');
66
67		$response = new \Phalcon\Http\Response();
68		$response->setHeader(403, 'Forbidden');
69		$response->sendHeaders();
70		echo $response->getContent();
71		exit;
72		}
73
74		private function resourceNotFound($resourceKey, View $view)
75		{
76		$view->setViewsDir(__DIR__ . '/../modules/Index/views/');
77		$view->setPartialsDir('');
78		$view->message = "Acl resource <b>$resourceKey</b> in <b>/app/config/acl.php</b> not exists";
79		$view->partial('error/error404');
80		$response = new \Phalcon\Http\Response();
81		$response->setHeader(404, 'Not Found');
82		$response->sendHeaders();
83		echo $response->getContent();
84		exit;
85		}
86
87	View Code Duplication	private function redirect($url, $code = 302)
88		{
89		switch ($code) {
90		case 301 :
91		header('HTTP/1.1 301 Moved Permanently');
92		break;
93		case 302 :
94		header('HTTP/1.1 302 Moved Temporarily');
95		break;
96		}
97		header('Location: ' . $url);
98		exit;
99		}
100
101		}

alexander-torosh / yona-cms

Issues (336)

Security Analysis not enabled

app/plugins/Acl.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like