Form::renderDecorated() - Code Metrics - alexander-torosh/yona-cms - Measure and Improve Code Quality continuously with Scrutinizer

Form::renderDecorated() B
last analyzed 2019-11-25 19:20 UTC

↳ Parent: Form

Complexity

Conditions	9
Paths	13

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	60
rs	7.3171
c	0
b	0
f	0
cc	9
nc	13
nop	1

How to fix Long Method

<?php

/**
 * Form
 * @copyright Copyright (c) 2011 - 2014 Aleksandr Torosh (http://wezoom.com.ua)
 * @author Aleksandr Torosh <[email protected]>
 */

namespace Application\Form;

use Phalcon\Forms\Element\Hidden;
use Phalcon\Forms\Element\Check;
use Phalcon\Forms\Element\File;
use Application\Form\Element\Image;

abstract class Form extends \Phalcon\Forms\Form
{

    protected $helper;

    public function renderDecorated($name)
    {
        if (!$this->has($name)) {
            return "form element '$name' not found<br />";
        }

        $this->helper = $this->getDI()->get('helper');


        $element = $this->get($name);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $messages = $this->getMessagesFor($element->getName());
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $html = '';
        if (count($messages)) {
            $html .= '<div class="ui error message">';
            $html .= '<div class="header">' . $this->helper->translate('Ошибка валидации формы') . '</div>';
            foreach ($messages as $message) {

                $html .= '<p>' . $message . '</p>';
            }
            $html .= '</div>';
        }

        if ($element instanceof Hidden) {
            echo $element;
        } else {
            switch (true) {
                case $element instanceof Check:
                    $html .= '<div class="field checkbox">';
                    $html .= '<div class="ui toggle checkbox">';
                    $html .= $element;
                    if ($element->getLabel()) {
                        $html .= '<label>';
                        $html .= $element->getLabel();
                        $html .= '</label>';
                    }
                    $html .= '</div>';
                    $html .= '</div>';
                    break;

                case $element instanceof Image:
                    $html = $this->renderImage($element);
                    break;

                case $element instanceof File:
                    $html .= '<div class="inline field">';
                    $html .= $this->makeLabel($element);
                    $html .= $element;
                    $html .= '</div>';
                    break;

                default:
                    $html .= '<div class="field">';
                    $html .= $this->makeLabel($element);
                    $html .= $element;
                    $html .= '</div>';
            }
        }

        return $html;

    }

    public function renderAll()
    {
        $html = '';
        if ($this->getElements()) {
            foreach ($this->getElements() as $element) {
                $html .= $this->renderDecorated($element->getName());
            }
        }
        return $html;
    }

    private function makeLabel($element)
    {
        if ($element->getLabel()) {
            return '<label for="' . $element->getName() . '">' . $this->helper->translate($element->getLabel()) . '</label>';
        } else {
            return '';
        }
    }

    /**
     * @param Image $element
     * @return string $html
     */
    private function renderImage($element)
    {
        $html = '<div class="form-group">';

        if ($element->getLabel()) {
            $html .= '<label>' . $element->getLabel() . '</label>';
        }
        if ($element->getValue()) {
            $html .= '<section onclick="selectText(this);">' . $element->getValue() . '</section>';
        } else {
            $html .= '<br>';
        }

        $html .= '<div class="fileinput fileinput-new" data-provides="fileinput">
                            <div class="fileinput-preview thumbnail" data-trigger="fileinput"
                                 style="width: 200px; min-height: 100px">';

        if ($element->getValue()) {
            $url = $this->getDI()->get('url');

            $html .= '<img src="' . $url->path() . $element->getValue() . '" width="200">';
        }

        $html .= '</div>
                        <div>
                            <span class="btn btn-default btn-file">
                                <span class="fileinput-new">Select image</span>
                                <span class="fileinput-exists">Change</span>
                                <input type="file" name="'.$element->getName() . '">
                            </span>
                            <a href="#" class="btn btn-default fileinput-exists"
                               data-dismiss="fileinput">Remove</a>
                        </div>
                    </div>
                </div>';

        return $html;
    }

}


1			<?php
2
3			/**
4			* Form
5			* @copyright Copyright (c) 2011 - 2014 Aleksandr Torosh (http://wezoom.com.ua)
6			* @author Aleksandr Torosh <[email protected]>
7			*/
8
9			namespace Application\Form;
10
11			use Phalcon\Forms\Element\Hidden;
12			use Phalcon\Forms\Element\Check;
13			use Phalcon\Forms\Element\File;
14			use Application\Form\Element\Image;
15
16			abstract class Form extends \Phalcon\Forms\Form
17			{
18
19			protected $helper;
20
21			public function renderDecorated($name)
22			{
23			if (!$this->has($name)) {
24			return "form element '$name' not found<br />";
25			}
26
27			$this->helper = $this->getDI()->get('helper');
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report The method `get` cannot be called on `$this->getDI()` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
28
29			$element = $this->get($name);
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$element` is correct as `$this->get($name)` (which targets `Phalcon\Forms\Form::get()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
30			$messages = $this->getMessagesFor($element->getName());
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report The method `getName` cannot be called on `$element` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history... Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$messages` is correct as `$this->getMessagesFor($element->getName())` (which targets `Phalcon\Forms\Form::getMessagesFor()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
31
32			$html = '';
33			if (count($messages)) {
34			$html .= '<div class="ui error message">';
35			$html .= '<div class="header">' . $this->helper->translate('Ошибка валидации формы') . '</div>';
36			foreach ($messages as $message) {
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report The expression `$messages` of type `null` is not traversable. Loading history...
37			$html .= '<p>' . $message . '</p>';
38			}
39			$html .= '</div>';
40			}
41
42			if ($element instanceof Hidden) {
43			echo $element;
44			} else {
45			switch (true) {
46			case $element instanceof Check:
47			$html .= '<div class="field checkbox">';
48			$html .= '<div class="ui toggle checkbox">';
49			$html .= $element;
50			if ($element->getLabel()) {
51			$html .= '<label>';
52			$html .= $element->getLabel();
53			$html .= '</label>';
54			}
55			$html .= '</div>';
56			$html .= '</div>';
57			break;
58
59			case $element instanceof Image:
60			$html = $this->renderImage($element);
61			break;
62
63			case $element instanceof File:
64			$html .= '<div class="inline field">';
65			$html .= $this->makeLabel($element);
66			$html .= $element;
67			$html .= '</div>';
68			break;
69
70			default:
71			$html .= '<div class="field">';
72			$html .= $this->makeLabel($element);
73			$html .= $element;
74			$html .= '</div>';
75			}
76			}
77
78			return $html;
79
80			}
81
82			public function renderAll()
83			{
84			$html = '';
85			if ($this->getElements()) {
86			foreach ($this->getElements() as $element) {
87			$html .= $this->renderDecorated($element->getName());
88			}
89			}
90			return $html;
91			}
92
93			private function makeLabel($element)
94			{
95			if ($element->getLabel()) {
96			return '<label for="' . $element->getName() . '">' . $this->helper->translate($element->getLabel()) . '</label>';
97			} else {
98			return '';
99			}
100			}
101
102			/**
103			* @param Image $element
104			* @return string $html
105			*/
106			private function renderImage($element)
107			{
108			$html = '<div class="form-group">';
109
110			if ($element->getLabel()) {
111			$html .= '<label>' . $element->getLabel() . '</label>';
112			}
113			if ($element->getValue()) {
114			$html .= '<section onclick="selectText(this);">' . $element->getValue() . '</section>';
115			} else {
116			$html .= '<br>';
117			}
118
119			$html .= '<div class="fileinput fileinput-new" data-provides="fileinput">
120			<div class="fileinput-preview thumbnail" data-trigger="fileinput"
121			style="width: 200px; min-height: 100px">';
122
123			if ($element->getValue()) {
124			$url = $this->getDI()->get('url');
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report The method `get` cannot be called on `$this->getDI()` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
125			$html .= '<img src="' . $url->path() . $element->getValue() . '" width="200">';
126			}
127
128			$html .= '</div>
129			<div>
130			<span class="btn btn-default btn-file">
131			<span class="fileinput-new">Select image</span>
132			<span class="fileinput-exists">Change</span>
133			<input type="file" name="'.$element->getName() . '">
134			</span>
135			<a href="#" class="btn btn-default fileinput-exists"
136			data-dismiss="fileinput">Remove</a>
137			</div>
138			</div>
139			</div>';
140
141			return $html;
142			}
143
144			}
145

alexander-torosh / yona-cms

Form::renderDecorated() B last analyzed 2019-11-25 19:20 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

Form::renderDecorated() B
last analyzed 2019-11-25 19:20 UTC