PageController::getAction() - Code Metrics - alexander-torosh/yona-cms - Measure and Improve Code Quality continuously with Scrutinizer

PageController::getAction() A
last analyzed 2019-11-25 19:20 UTC

↳ Parent: PageController

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.7666
c	0
b	0
f	0
cc	3
nc	2
nop	0

<?php

namespace Api\Controller;

/**
 * Class PageController.
 * Class is responsible for handling Page entity via REST API.
 *
 * @package Api\Controller
 */
class PageController extends \Api\Controller\RestController
{
    /**
     * Action responsible to display info about single page entity.
     *
     * @return \Phalcon\Http\ResponseInterface
     * @throws \Api\Exception\NotImplementedException
     */
    public function getAction()
    {
        //get entity from storage
        $pageId = (int) $this->request->getQuery('pageId');
        $page = \Page\Model\Page::findFirst($pageId);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        if (!$pageId || !$page) {
            return $this->render(new \Api\Model\Payload(null, sprintf('Page with id: %s was not found.', $pageId)));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        //filter required data for display
        $filter = new \Api\Filter\Page();
        $payload = new \Api\Model\Payload($filter->filter($page));

        return $this->render($payload);
    }

    /**
     * Action responsible to display a list of pages with required data.
     *
     * @return \Phalcon\Http\ResponseInterface
     * @throws \Api\Exception\NotImplementedException
     */
    public function listAction()
    {
        $pages = \Page\Model\Page::find();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $filter = new \Api\Filter\PagesList();
        $payload = new \Api\Model\Payload($filter->filter($pages));

        return $this->render($payload);
    }
}


1			<?php
2
3			namespace Api\Controller;
4
5			/**
6			* Class PageController.
7			* Class is responsible for handling Page entity via REST API.
8			*
9			* @package Api\Controller
10			*/
11			class PageController extends \Api\Controller\RestController
12			{
13			/**
14			* Action responsible to display info about single page entity.
15			*
16			* @return \Phalcon\Http\ResponseInterface
17			* @throws \Api\Exception\NotImplementedException
18			*/
19			public function getAction()
20			{
21			//get entity from storage
22			$pageId = (int) $this->request->getQuery('pageId');
23			$page = \Page\Model\Page::findFirst($pageId);
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$page` is correct as `\Page\Model\Page::findFirst($pageId)` (which targets `Phalcon\Mvc\Model::findFirst()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
24			if (!$pageId \|\| !$page) {
25			return $this->render(new \Api\Model\Payload(null, sprintf('Page with id: %s was not found.', $pageId)));
			0 ignored issues – show Documentation introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report `sprintf('Page with id: %...s not found.', $pageId)` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26			}
27
28			//filter required data for display
29			$filter = new \Api\Filter\Page();
30			$payload = new \Api\Model\Payload($filter->filter($page));
31
32			return $this->render($payload);
33			}
34
35			/**
36			* Action responsible to display a list of pages with required data.
37			*
38			* @return \Phalcon\Http\ResponseInterface
39			* @throws \Api\Exception\NotImplementedException
40			*/
41			public function listAction()
42			{
43			$pages = \Page\Model\Page::find();
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$pages` is correct as `\Page\Model\Page::find()` (which targets `Phalcon\Mvc\Model::find()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
44			$filter = new \Api\Filter\PagesList();
45			$payload = new \Api\Model\Payload($filter->filter($pages));
46
47			return $this->render($payload);
48			}
49			}
50

alexander-torosh / yona-cms

PageController::getAction() A last analyzed 2019-11-25 19:20 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

PageController::getAction() A
last analyzed 2019-11-25 19:20 UTC