AdminUserController::deleteAction() - Code Metrics - alexander-torosh/yona-cms - Measure and Improve Code Quality continuously with Scrutinizer

AdminUserController::deleteAction() A
last analyzed 2019-11-25 19:20 UTC

↳ Parent: AdminUserController

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	22
rs	9.568
c	0
b	0
f	0
cc	4
nc	4
nop	1

<?php

/**
 * AdminUserController
 * @copyright Copyright (c) 2011 - 2014 Aleksandr Torosh (http://wezoom.com.ua)
 * @author Aleksandr Torosh <[email protected]>
 */

namespace Admin\Controller;

use Application\Mvc\Controller;
use Admin\Form\AdminUserForm;
use Admin\Model\AdminUser;

class AdminUserController extends Controller
{

    public function initialize()
    {
        $this->setAdminEnvironment();
        $this->helper->activeMenu()->setActive('admin-user');

        $this->view->languages_disabled = true;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public function indexAction()
    {
        $this->view->entries = AdminUser::find([
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            "order" => "id DESC"
        ]);

        $this->helper->title($this->helper->at('Manage Users'), true);
    }

    public function addAction()
    {
        $this->view->pick(['admin-user/edit']);

        $model = new AdminUser();
        $form = new AdminUserForm();
        $form->initAdding();

        if ($this->request->isPost()) {
            $model = new AdminUser();
            $post = $this->request->getPost();
            $form->bind($post, $model);
            if ($form->isValid()) {
                $model->setCheckboxes($post);
                if ($model->save()) {
                    $this->flash->success($this->helper->at('User created', ['name' => $model->getLogin()]));
                    $this->redirect($this->url->get() . 'admin/admin-user');
                } else {
                    $this->flashErrors($model);
                }
            } else {
                $this->flashErrors($form);
            }
        }

        $this->view->form = $form;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->view->model = $model;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->view->submitButton = $this->helper->at('Add New');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $this->helper->title($this->helper->at('Administrator'), true);
    }

    public function editAction($id)
    {
        $model = AdminUser::findFirst($id);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        if (!$model) {
            $this->redirect($this->url->get() . 'admin/admin-user');
        }

        $form = new AdminUserForm();

        if ($this->request->isPost()) {
            $post = $this->request->getPost();
            $form->bind($post, $model);
            if ($form->isValid()) {
                $model->setCheckboxes($post);

                if ($model->save() == true) {

                    $this->flash->success('User [' . $model->getLogin() . '] has been saved');

                    return $this->redirect($this->url->get() . 'admin/admin-user');
                } else {
                    $this->flashErrors($model);
                }
            } else {
                $this->flashErrors($form);
            }
        } else {
            $form->setEntity($model);
        }

        $this->view->submitButton = $this->helper->at('Save');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->view->form = $form;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->view->model = $model;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $this->helper->title($this->helper->at('Manage Users'), true);
    }

    public function deleteAction($id)
    {
        $model = AdminUser::findFirst($id);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        if (!$model) {
            return $this->redirect($this->url->get() . 'admin/admin-user');
        }

        if ($model->getLogin() == 'admin') {
            $this->flash->error('Admin user cannot be deleted');
            return $this->redirect($this->url->get() . 'admin/admin-user');
        }

        if ($this->request->isPost()) {
            $model->delete();
            $this->flash->warning('Deleting user [' . $model->getLogin() . ']');
            return $this->redirect($this->url->get() . 'admin/admin-user');
        }

        $this->view->model = $model;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $this->helper->title($this->helper->at('Delete User'), true);
    }

}


1			<?php
2
3			/**
4			* AdminUserController
5			* @copyright Copyright (c) 2011 - 2014 Aleksandr Torosh (http://wezoom.com.ua)
6			* @author Aleksandr Torosh <[email protected]>
7			*/
8
9			namespace Admin\Controller;
10
11			use Application\Mvc\Controller;
12			use Admin\Form\AdminUserForm;
13			use Admin\Model\AdminUser;
14
15			class AdminUserController extends Controller
16			{
17
18			public function initialize()
19			{
20			$this->setAdminEnvironment();
21			$this->helper->activeMenu()->setActive('admin-user');
22
23			$this->view->languages_disabled = true;
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `languages_disabled` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
24			}
25
26			public function indexAction()
27			{
28			$this->view->entries = AdminUser::find([
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `entries` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$this->view->entries` is correct as `\Admin\Model\AdminUser::...('order' => 'id DESC'))` (which targets `Phalcon\Mvc\Model::find()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
29			"order" => "id DESC"
30			]);
31
32			$this->helper->title($this->helper->at('Manage Users'), true);
33			}
34
35			public function addAction()
36			{
37			$this->view->pick(['admin-user/edit']);
38
39			$model = new AdminUser();
40			$form = new AdminUserForm();
41			$form->initAdding();
42
43			if ($this->request->isPost()) {
44			$model = new AdminUser();
45			$post = $this->request->getPost();
46			$form->bind($post, $model);
47			if ($form->isValid()) {
48			$model->setCheckboxes($post);
49			if ($model->save()) {
50			$this->flash->success($this->helper->at('User created', ['name' => $model->getLogin()]));
51			$this->redirect($this->url->get() . 'admin/admin-user');
52			} else {
53			$this->flashErrors($model);
54			}
55			} else {
56			$this->flashErrors($form);
57			}
58			}
59
60			$this->view->form = $form;
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `form` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
61			$this->view->model = $model;
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `model` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
62			$this->view->submitButton = $this->helper->at('Add New');
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `submitButton` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
63
64			$this->helper->title($this->helper->at('Administrator'), true);
65			}
66
67			public function editAction($id)
68			{
69			$model = AdminUser::findFirst($id);
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$model` is correct as `\Admin\Model\AdminUser::findFirst($id)` (which targets `Phalcon\Mvc\Model::findFirst()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
70			if (!$model) {
71			$this->redirect($this->url->get() . 'admin/admin-user');
72			}
73
74			$form = new AdminUserForm();
75
76			if ($this->request->isPost()) {
77			$post = $this->request->getPost();
78			$form->bind($post, $model);
79			if ($form->isValid()) {
80			$model->setCheckboxes($post);
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report The method `setCheckboxes` cannot be called on `$model` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
81			if ($model->save() == true) {
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report The method `save` cannot be called on `$model` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
82			$this->flash->success('User [' . $model->getLogin() . '] has been saved');
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report The method `getLogin` cannot be called on `$model` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
83			return $this->redirect($this->url->get() . 'admin/admin-user');
84			} else {
85			$this->flashErrors($model);
86			}
87			} else {
88			$this->flashErrors($form);
89			}
90			} else {
91			$form->setEntity($model);
92			}
93
94			$this->view->submitButton = $this->helper->at('Save');
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `submitButton` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
95			$this->view->form = $form;
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `form` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
96			$this->view->model = $model;
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `model` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
97
98			$this->helper->title($this->helper->at('Manage Users'), true);
99			}
100
101			public function deleteAction($id)
102			{
103			$model = AdminUser::findFirst($id);
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$model` is correct as `\Admin\Model\AdminUser::findFirst($id)` (which targets `Phalcon\Mvc\Model::findFirst()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
104			if (!$model) {
105			return $this->redirect($this->url->get() . 'admin/admin-user');
106			}
107
108			if ($model->getLogin() == 'admin') {
109			$this->flash->error('Admin user cannot be deleted');
110			return $this->redirect($this->url->get() . 'admin/admin-user');
111			}
112
113			if ($this->request->isPost()) {
114			$model->delete();
115			$this->flash->warning('Deleting user [' . $model->getLogin() . ']');
116			return $this->redirect($this->url->get() . 'admin/admin-user');
117			}
118
119			$this->view->model = $model;
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `model` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
120
121			$this->helper->title($this->helper->at('Delete User'), true);
122			}
123
124			}
125

alexander-torosh / yona-cms

AdminUserController::deleteAction() A last analyzed 2019-11-25 19:20 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

AdminUserController::deleteAction() A
last analyzed 2019-11-25 19:20 UTC