Sitemap\Controller\IndexController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	100
Duplicated Lines	7 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	initialize()	0	26	1
B	indexAction()	0	45	10
A	langUrlCustom()	7	7	1
A	getRawXml()	0	10	1

<?php

namespace Sitemap\Controller;

use Application\Mvc\Controller;
use Cms\Model\Language;
use Application\Mvc\Router\DefaultRouter;


class IndexController extends Controller
{
    private $cacheViewKey;
    private $models;
    private $links = [];

    public function initialize()
    {
        $this->cacheViewKey =  HOST_HASH . md5('Sitemap\Model\Sitemap');

        $this->models = [
            [
                'class' => 'Publication',
                'model' => 'Publication',
                'where' => "", // preview_inner='0'  ,  etc.
                'getLink' => function($model, $lang){
                    return $this->langUrlCustom([
                        'for' => 'publication',
                        'type' => $model->getTypeSlug(),
                        'slug' => $model->getSlug()], $lang);
                }
            ],[
                'class' => 'Page',
                'model' => 'Page',
                'getLink'      => function($model, $lang){
                    return $this->langUrlCustom([
                        'for' => 'page',
                        'slug' => $model->getSlug()], $lang);
                },
            ]
        ];
    }


    public function indexAction()
    {
        $this->view->setRenderLevel( \Phalcon\Mvc\View::LEVEL_NO_RENDER );
        $cache = $this->getDi()->get('cache');

The method get cannot be called on $this->getDi() (of type null).

        $sitemap_xml = $cache->get($this->cacheViewKey);

        if(!$sitemap_xml){
            $langs = Language::find(['columns' => 'iso,primary']);

Are you sure the assignment to $langs is correct as \Cms\Model\Language::find(array('columns' => 'iso,primary')) (which targets Phalcon\Mvc\Model::find()) seems to always return null.

            //link(s) for main-page(s)
            foreach ($langs as $lang){

The expression $langs of type null is not traversable.

                $suffix = !$lang['primary'] ? $lang['iso'] . '/' : '';
                $this->links[] = [
                    'url' => 'http://' . $_SERVER['HTTP_HOST'] .  '/' . $suffix,
                    'updated_at' => date('c',time()),
                ];
            }

            foreach ($this->models as $m) {
                $class_name = '\\' . $m['class'] . '\Model\\' . $m['model'];
                $where      = !empty($m['where']) ? $m['where'] : '';

                $rows = $class_name::find($where);

                foreach ($langs as $lang) {

The expression $langs of type null is not traversable.

                    foreach ($rows as $row) {
                        $row::setCustomLang($lang->iso);
                        if($row->getSlug() !== 'index' && $row->getTitle()){
                            $this->links[] = [
                                'url'        => 'http://' . $_SERVER['HTTP_HOST'] .  $m['getLink']($row, $lang->iso),
                                'updated_at' => date('c', strtotime($row->getUpdatedAt())),
                            ];
                        }
                    }
                }

                $sitemap_xml = $this->getRawXml();
                $cache->save($this->cacheViewKey, $sitemap_xml);
            }
        }

        $this->response->setHeader("Content-Type", "text/xml");
        $this->response->setContent($sitemap_xml);
        return $this->response->send();
    }

    public function langUrlCustom($params, $lang)
    {
        $routeName = $params['for'];
        $routeName = DefaultRouter::ML_PREFIX . $routeName . '_' . $lang;
        $params['for'] = $routeName;
        return $this->url->get($params);
    }

    private function getRawXml()
    {
        $this->view->setRenderLevel( \Phalcon\Mvc\View::LEVEL_ACTION_VIEW );
        $this->view->links = $this->links;

Accessing links on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->view->start();
        $this->view->setLayoutsDir('../views/');
        $this->view->render('index', 'index');
        $this->view->finish();
        return $this->view->getContent();
    }

}