Seo\Controller\SitemapController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	42
Duplicated Lines	57.14 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	initialize()	7	7	1
A	indexAction()	17	27	4

<?php

namespace Seo\Controller;

use Application\Mvc\Controller;
use Seo\Form\SitemapForm;

class SitemapController extends Controller
{

    private $sitemapFilePath;

    public function initialize()
    {
        $this->setAdminEnvironment();
        $this->helper->activeMenu()->setActive('seo-sitemap');
        $this->sitemapFilePath = ROOT . '/sitemap.xml';
        $this->view->languages_disabled = true;

Accessing languages_disabled on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function indexAction()
    {
        $form = new SitemapForm();

        if ($this->request->isPost()) {
            if ($form->isValid()) {
                $sitemap = $this->request->getPost('sitemap');
                $result = file_put_contents($this->sitemapFilePath, $sitemap);
                if ($result) {
                    $this->flash->success('File sitemap.xml has been saved');
                    $this->redirect($this->url->get() . 'seo/sitemap');
                } else {
                    $this->flash->error('Error! The sitemap.xml file is not updated. Check the write permissions to the file.');
                }
            } else {
                $this->flashErrors($form);
            }
        } else {
            $sitemap = file_get_contents($this->sitemapFilePath);
            $form->get('sitemap')->setDefault($sitemap);

The method setDefault cannot be called on $form->get('sitemap') (of type null).

        }

        $title = 'Editing sitemap.xml';
        $this->helper->title($title);
        $this->view->title = $title;

Accessing title on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->view->form = $form;

Accessing form on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

}