Publication\Controller\TypeController

Complexity

Total Complexity

14

Size/Duplication

Total Lines	97
Duplicated Lines	34.02 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	initialize()	0	4	1
A	indexAction()	0	6	1
A	addAction()	33	33	5
A	editAction()	0	28	4
A	deleteAction()	0	17	3

<?php
/**
 * @copyright Copyright (c) 2011 - 2014 Oleksandr Torosh (http://wezoom.net)
 * @author Oleksandr Torosh <web@wezoom.net>
 */

namespace Publication\Controller;

use Application\Mvc\Controller;
use Publication\Form\TypeForm;
use Publication\Model\Type;

class TypeController extends Controller
{

    public function initialize()
    {
        $this->setAdminEnvironment();
    }

    public function indexAction()
    {
        $this->view->entries = Type::find();

Accessing entries on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

Are you sure the assignment to $this->view->entries is correct as \Publication\Model\Type::find() (which targets Phalcon\Mvc\Model::find()) seems to always return null.

        $this->helper->title('Manage Types of Publication', true);
    }

    public function addAction()
    {
        $this->view->pick(array('type/edit'));

        $form = new TypeForm();
        $model = new Type();

        if ($this->request->isPost()) {
            $post = $this->request->getPost();
            $form->bind($post, $model);

            if ($form->isValid()) {
                if ($model->create()) {
                    $form->bind($post, $model);
                    $model->updateFields($post);
                    if ($model->update()) {
                        $this->flash->success('Type created');
                        return $this->redirect($this->url->get() . 'publication/type/edit/' . $model->getId() . '?lang=' . LANG);
                    } else {
                        $this->flashErrors($model);
                    }
                } else {
                    $this->flashErrors($model);
                }
            } else {
                $this->flashErrors($form);
            }
        }

        $this->view->model = $model;

Accessing model on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->view->form = $form;

Accessing form on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->helper->title($this->helper->at('Adding Type of Publication'));
    }

    public function editAction($id)
    {
        $form = new TypeForm();
        $model = Type::findFirst($id);

Are you sure the assignment to $model is correct as \Publication\Model\Type::findFirst($id) (which targets Phalcon\Mvc\Model::findFirst()) seems to always return null.

        if ($this->request->isPost()) {
            $post = $this->request->getPost();
            $form->bind($post, $model);

            if ($form->isValid()) {
                $model->updateFields($post);

The method updateFields cannot be called on $model (of type null).

                if ($model->update()) {

The method update cannot be called on $model (of type null).

                    $this->flash->success('Type created');
                    return $this->redirect($this->url->get() . 'publication/type/edit/' . $model->getId() . '?lang=' . LANG);

The method getId cannot be called on $model (of type null).

                } else {
                    $this->flashErrors($model);
                }
            } else {
                $this->flashErrors($form);
            }
        } else {
            $form->setEntity($model);
        }

        $this->view->model = $model;

Accessing model on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->view->form = $form;

Accessing form on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->helper->title($this->helper->at('Manage Type of Publication'));
    }

    public function deleteAction($id)
    {
        $model = Type::findFirst($id);

Are you sure the assignment to $model is correct as \Publication\Model\Type::findFirst($id) (which targets Phalcon\Mvc\Model::findFirst()) seems to always return null.

        $count = Type::count();
        if ($count == 1) {
            $this->flash->error($this->helper->at('Can not Delete the last Publication Type'));
            return;
        }

        if ($this->request->isPost()) {
            $model->delete();

The method delete cannot be called on $model (of type null).

            $this->redirect($this->url->get() . 'publication/type');
        }

        $this->view->model = $model;

Accessing model on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->helper->title($this->helper->at('Delete Type'));
    }

}