Page\Controller\AdminController

Complexity

Total Complexity

15

Size/Duplication

Total Lines	108
Duplicated Lines	29.63 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	initialize()	0	6	1
A	indexAction()	0	6	1
A	addAction()	32	32	5
A	editAction()	0	38	5
A	deleteAction()	0	17	3

<?php
/**
 * Created by PhpStorm.
 * User: office-pb1
 * Date: 18.07.14
 * Time: 20:49
 */

namespace Page\Controller;

use Application\Mvc\Controller;
use Page\Model\Page;
use Page\Form\PageForm;

class AdminController extends Controller
{

    public function initialize()
    {
        $this->setAdminEnvironment();
        $this->helper->activeMenu()->setActive('admin-page');
        Page::setTranslateCache(false);
    }

    public function indexAction()
    {
        $this->view->entries = Page::find();

Accessing entries on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

Are you sure the assignment to $this->view->entries is correct as \Page\Model\Page::find() (which targets Phalcon\Mvc\Model::find()) seems to always return null.

        $this->helper->title($this->helper->at('Manage Pages'), true);
    }

    public function addAction()
    {
        $this->view->pick(['admin/edit']);
        $form = new PageForm();
        $model = new Page();

        if ($this->request->isPost()) {
            $post = $this->request->getPost();
            $form->bind($post, $model);
            if ($form->isValid()) {
                if ($model->create()) {
                    $form->bind($post, $model);
                    $model->updateFields($post);
                    if ($model->update()) {
                        $this->flash->success($this->helper->at('Page created'));
                        return $this->redirect($this->url->get() . 'page/admin/edit/' . $model->getId() . '?lang=' . LANG);
                    } else {
                        $this->flashErrors($model);
                    }
                } else {
                    $this->flashErrors($model);
                }
            } else {
                $this->flashErrors($form);
            }
        }

        $this->helper->title($this->helper->at('Manage Pages'), true);

        $this->view->model = $model;

Accessing model on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->view->form = $form;

Accessing form on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function editAction($id)
    {
        $id = (int) $id;
        $form = new PageForm();
        $model = Page::findFirst($id);

Are you sure the assignment to $model is correct as \Page\Model\Page::findFirst($id) (which targets Phalcon\Mvc\Model::findFirst()) seems to always return null.

        if ($model->getSlug() == 'index') {

The method getSlug cannot be called on $model (of type null).

            $form->get('slug')->setAttribute('disabled', 'disabled');

The method setAttribute cannot be called on $form->get('slug') (of type null).

        }

        if ($this->request->isPost()) {
            $post = $this->request->getPost();
            $form->bind($post, $model);
            if ($form->isValid()) {
                $model->updateFields($post);

The method updateFields cannot be called on $model (of type null).

                if ($model->save()) {

The method save cannot be called on $model (of type null).

                    $this->flash->success($this->helper->at('Updated has been successful'));

                    // Очищаем кеш страницы
                    $query = "slug = '{$model->getSlug()}'";

The method getSlug cannot be called on $model (of type null).

                    $key = md5("Page::findFirst($query)");
                    $this->cache->delete($key);

                    return $this->redirect($this->url->get() . 'page/admin/edit/' . $model->getId() . '?lang=' . LANG);

The method getId cannot be called on $model (of type null).

                } else {
                    $this->flashErrors($model);
                }
            } else {
                $this->flashErrors($form);
            }
        } else {
            $form->setEntity($model);
        }

        $this->view->model = $model;

Accessing model on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->view->form = $form;

Accessing form on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->helper->title($this->helper->at('Edit Page'), true);
    }

    public function deleteAction($id)
    {
        $model = Page::findFirst($id);

Are you sure the assignment to $model is correct as \Page\Model\Page::findFirst($id) (which targets Phalcon\Mvc\Model::findFirst()) seems to always return null.

        if ($model->getSlug() == 'index') {

The method getSlug cannot be called on $model (of type null).

            $this->flash->error($this->helper->at('Index page can not be removed'));
            return $this->redirect($this->url->get() . 'page/admin');
        }

        if ($this->request->isPost()) {
            $model->delete();

The method delete cannot be called on $model (of type null).

            $this->redirect($this->url->get() . 'page/admin');
        }

        $this->view->model = $model;

Accessing model on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->helper->title($this->helper->at('Delete Page'), true);
    }

}