LanguageController - Code Metrics - alexander-torosh/yona-cms - Measure and Improve Code Quality continuously with Scrutinizer

LanguageController A
last analyzed 2019-11-25 19:20 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	96
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

Metric	Value
dl	0
loc	96
rs	10
c	0
b	0
f	0
wmc	13
lcom	1
cbo	6

5 Methods

Rating	Name	Size	Complexity
A	initialize()	7	1
A	indexAction()	9	1
A	addAction()	27	4
A	editAction()	30	5
A	deleteAction()	14	2

<?php
/**
 * @copyright Copyright (c) 2011 - 2014 Aleksandr Torosh (http://wezoom.net)
 * @author Aleksandr Torosh <[email protected]>
 */

namespace Cms\Controller;

use Application\Mvc\Controller;
use Cms\Form\LanguageForm;
use Cms\Model\Language;

class LanguageController extends Controller
{

    public function initialize()
    {
        $this->setAdminEnvironment();
        $this->helper->activeMenu()->setActive('admin-language');
        $this->view->languages_disabled = true;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

    }

    public function indexAction()
    {
        $this->view->entries = Language::find(array(
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            'order' => 'primary DESC, sortorder ASC',
        ));

        $this->view->title = $this->helper->at('Manage Languages');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->helper->title($this->view->title);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public function addAction()
    {
        $this->view->pick(array('language/edit'));
        $form = new LanguageForm();
        $model = new Language();

        if ($this->request->isPost()) {
            $form->bind($this->request->getPost(), $model);
            if ($form->isValid()) {
                if ($model->save()) {
                    $this->cache->delete(Language::cacheKey());
                    $this->flash->success($this->helper->at('Updated has been successful'));
                    return $this->redirect($this->url->get() . 'cms/language');
                } else {
                    $this->flashErrors($model);
                }
            } else {
                $this->flashErrors($form);
            }
        }

        $this->view->model = $model;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->view->form = $form;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $this->view->title = $this->helper->at('Adding language');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->helper->title($this->view->title);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public function editAction($id)
    {
        $form = new LanguageForm();
        $model = Language::findFirst($id);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        if ($this->request->isPost()) {
            $form->bind($this->request->getPost(), $model);
            if ($form->isValid()) {
                ($this->request->getPost('primary') != null) ? $model->setPrimary(1) : $model->setPrimary(0);

                if ($model->save()) {

                    $model->setOnlyOnePrimary();

                    $this->flash->success($this->helper->at('Updated has been successful'));
                    $this->cache->delete(Language::cacheKey());
                    return $this->redirect($this->url->get() . 'cms/language/edit/' . $model->getId());

                } else {
                    $this->flashErrors($model);
                }
            } else {
                $this->flashErrors($form);
            }
        } else {
            $form->setEntity($model);
        }

        $this->view->model = $model;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->view->form = $form;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $this->view->title = 'Editing language';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->helper->title($this->view->title);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public function deleteAction($id)
    {
        $model = Language::findFirst($id);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        if ($this->request->isPost()) {
            $this->cache->delete(Language::cacheKey());
            $model->delete();

            return $this->redirect($this->url->get() . 'cms/language');
        }

        $this->view->model = $model;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->view->title = $this->helper->at('Removing language');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->helper->title($this->view->title);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

} 

1			<?php
2			/**
3			* @copyright Copyright (c) 2011 - 2014 Aleksandr Torosh (http://wezoom.net)
4			* @author Aleksandr Torosh <[email protected]>
5			*/
6
7			namespace Cms\Controller;
8
9			use Application\Mvc\Controller;
10			use Cms\Form\LanguageForm;
11			use Cms\Model\Language;
12
13			class LanguageController extends Controller
14			{
15
16			public function initialize()
17			{
18			$this->setAdminEnvironment();
19			$this->helper->activeMenu()->setActive('admin-language');
20			$this->view->languages_disabled = true;
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `languages_disabled` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
21
22			}
23
24			public function indexAction()
25			{
26			$this->view->entries = Language::find(array(
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `entries` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$this->view->entries` is correct as `\Cms\Model\Language::fin... DESC, sortorder ASC'))` (which targets `Phalcon\Mvc\Model::find()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
27			'order' => 'primary DESC, sortorder ASC',
28			));
29
30			$this->view->title = $this->helper->at('Manage Languages');
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `title` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
31			$this->helper->title($this->view->title);
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `title` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
32			}
33
34			public function addAction()
35			{
36			$this->view->pick(array('language/edit'));
37			$form = new LanguageForm();
38			$model = new Language();
39
40			if ($this->request->isPost()) {
41			$form->bind($this->request->getPost(), $model);
42			if ($form->isValid()) {
43			if ($model->save()) {
44			$this->cache->delete(Language::cacheKey());
45			$this->flash->success($this->helper->at('Updated has been successful'));
46			return $this->redirect($this->url->get() . 'cms/language');
47			} else {
48			$this->flashErrors($model);
49			}
50			} else {
51			$this->flashErrors($form);
52			}
53			}
54
55			$this->view->model = $model;
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `model` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
56			$this->view->form = $form;
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `form` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
57
58			$this->view->title = $this->helper->at('Adding language');
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `title` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
59			$this->helper->title($this->view->title);
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `title` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
60			}
61
62			public function editAction($id)
63			{
64			$form = new LanguageForm();
65			$model = Language::findFirst($id);
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$model` is correct as `\Cms\Model\Language::findFirst($id)` (which targets `Phalcon\Mvc\Model::findFirst()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
66
67			if ($this->request->isPost()) {
68			$form->bind($this->request->getPost(), $model);
69			if ($form->isValid()) {
70			($this->request->getPost('primary') != null) ? $model->setPrimary(1) : $model->setPrimary(0);
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report The method `setPrimary` cannot be called on `$model` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
71			if ($model->save()) {
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report The method `save` cannot be called on `$model` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
72			$model->setOnlyOnePrimary();
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report The method `setOnlyOnePrimary` cannot be called on `$model` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
73			$this->flash->success($this->helper->at('Updated has been successful'));
74			$this->cache->delete(Language::cacheKey());
75			return $this->redirect($this->url->get() . 'cms/language/edit/' . $model->getId());
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report The method `getId` cannot be called on `$model` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
76			} else {
77			$this->flashErrors($model);
78			}
79			} else {
80			$this->flashErrors($form);
81			}
82			} else {
83			$form->setEntity($model);
84			}
85
86			$this->view->model = $model;
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `model` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
87			$this->view->form = $form;
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `form` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
88
89			$this->view->title = 'Editing language';
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `title` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
90			$this->helper->title($this->view->title);
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `title` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
91			}
92
93			public function deleteAction($id)
94			{
95			$model = Language::findFirst($id);
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$model` is correct as `\Cms\Model\Language::findFirst($id)` (which targets `Phalcon\Mvc\Model::findFirst()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
96
97			if ($this->request->isPost()) {
98			$this->cache->delete(Language::cacheKey());
99			$model->delete();
			0 ignored issues – show Bug introduced 2018-03-22 08:36 UTC by Report Bug Copy Issue Report The method `delete` cannot be called on `$model` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
100			return $this->redirect($this->url->get() . 'cms/language');
101			}
102
103			$this->view->model = $model;
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `model` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
104			$this->view->title = $this->helper->at('Removing language');
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `title` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
105			$this->helper->title($this->view->title);
			0 ignored issues – show Bug introduced 2016-09-12 07:35 UTC by Report Bug Copy Issue Report Accessing `title` on the interface `Phalcon\Mvc\ViewInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
106			}
107
108			}

alexander-torosh / yona-cms

LanguageController A last analyzed 2019-11-25 19:20 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

LanguageController A
last analyzed 2019-11-25 19:20 UTC