Cms\Controller\ConfigurationController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	initialize()	0	7	1
A	indexAction()	0	23	4
A	saveFormData()	0	22	5

<?php
/**
     * @copyright Copyright (c) 2011 - 2014 Aleksandr Torosh (http://wezoom.com.ua)
     * @author Aleksandr Torosh <webtorua@gmail.com>
     */

namespace Cms\Controller;

use Application\Mvc\Controller;
use Cms\Form\ConfigurationForm;
use Cms\Model\Configuration;

class ConfigurationController extends Controller
{

    public function initialize()
    {
        $this->setAdminEnvironment();
        $this->helper->activeMenu()->setActive('admin-cms');
        $this->view->languages_disabled = true;

Accessing languages_disabled on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function indexAction()
    {
        $model = new Configuration();

        $form = new ConfigurationForm();

        if ($this->request->isPost()) {
            $post = $this->request->getPost();
            if ($form->isValid($post)) {
                if ($this->saveFormData($post)) {
                    $this->flash->success($this->helper->at('Configuration saved'));
                    $this->redirect($this->url->get() . 'cms/configuration');
                }
            } else {
                $this->flashErrors($form);
            }
        } else {
            $form->setEntity($model->buildFormData());
        }

        $this->view->form = $form;

Accessing form on the interface Phalcon\Mvc\ViewInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->helper->title($this->helper->at('CMS Configuration'), true);
    }

    public function saveFormData($post)
    {
        $result = true;
        foreach (Configuration::$keys as $key => $value) {
            $model = Configuration::findFirst("key = '$key'");

Are you sure the assignment to $model is correct as \Cms\Model\Configuration::findFirst("key = '{$key}'") (which targets Phalcon\Mvc\Model::findFirst()) seems to always return null.

            if (!$model) {
                $model = new Configuration();
                $model->setKey($key);
            }
            if (array_key_exists($key, $post)) {
                $model->setValue($post[$key]);
            } else {
                $model->setValue($value);
            }
            $model->updateCheckboxes($post);
            if (!$model->save()) {
                $result = false;
                $this->flashErrors($model);
            }
        }
        return $result;
    }

}