Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
14 | class Helper extends \Phalcon\Mvc\User\Component |
||
15 | { |
||
16 | const StaticWidgetDefaultOptions = [ |
||
17 | 'lifetime' => 120 |
||
18 | ]; |
||
19 | |||
20 | private $translate = null; |
||
21 | private $admin_translate = null; |
||
22 | |||
23 | public $menu; |
||
24 | |||
25 | public function __construct() |
||
29 | |||
30 | /** |
||
31 | * Мультиязычный перевод строки по сайту/пользовательской_части |
||
32 | */ |
||
33 | View Code Duplication | public function translate($string, $placeholders = null) |
|
41 | |||
42 | /** |
||
43 | * Мультиязычный перевод строки по админке |
||
44 | */ |
||
45 | View Code Duplication | public function at($string, $placeholders = null) |
|
53 | |||
54 | public function widget($namespace = 'Index', array $params = []) |
||
58 | |||
59 | /** |
||
60 | * Вызов выджета из модуля StaticWidget |
||
61 | * @param $id - идентификатор виджета, например "phone" |
||
62 | */ |
||
63 | public function staticWidget($id, $params = []) |
||
71 | |||
72 | View Code Duplication | public function langUrl($params) |
|
79 | |||
80 | public function languages() |
||
85 | |||
86 | public function langSwitcher($lang, $string) |
||
91 | |||
92 | public function cacheExpire($seconds) |
||
100 | |||
101 | public function isAdminSession() |
||
111 | |||
112 | public function error($code = 404) |
||
118 | |||
119 | public function title($title = null, $h1 = false) |
||
123 | |||
124 | public function meta() |
||
128 | |||
129 | public function activeMenu() |
||
133 | |||
134 | public function announce($incomeString, $num) |
||
139 | |||
140 | public function dbProfiler() |
||
145 | |||
146 | public function constant($name) |
||
150 | |||
151 | public function image($args, $attributes = []) |
||
156 | |||
157 | public function querySymbol() |
||
162 | |||
163 | public function javascript($id) |
||
170 | |||
171 | public function modulePartial($template, $data, $module = null) |
||
183 | |||
184 | } |
||
185 |
Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects.