alex19pov31 / bitrix-helper

src/Iblock/IblockModel.php

<?php

namespace Alex19pov31\BitrixHelper\Iblock;

use Bitrix\Main\ORM\Query\Result;

The type Bitrix\Main\ORM\Query\Result was not found. Maybe you did not declare it correctly or list all dependencies?

use Bitrix\Main\ORM\Data\AddResult;

The type Bitrix\Main\ORM\Data\AddResult was not found. Maybe you did not declare it correctly or list all dependencies?

use Bitrix\Main\ORM\Data\UpdateResult;

The type Bitrix\Main\ORM\Data\UpdateResult was not found. Maybe you did not declare it correctly or list all dependencies?

use Bitrix\Main\ORM\Data\DeleteResult;

The type Bitrix\Main\ORM\Data\DeleteResult was not found. Maybe you did not declare it correctly or list all dependencies?

abstract class IblockModel
{
    const TTL = 3600;

    /**
     * Объект для работы с инфоблоком
     *
     * @var IblockElementTable
     */
    private static $entity;

    abstract protected static function getIblockCode(): string;

    /**
     * Возвращает элемент по идентификатору
     *
     * @param integer $id
     * @return array|null
     */
    public static function getById(int $id)
    {
        return static::getList([
            'filter' => [
                'ID' => $id,
            ],
        ])->fetch();
    }

    /**
     * Список элементов
     *
     * @param array $params
     * @return Result
     */
    public static function getList(array $params): Result
    {
        if (empty($params['cache'])) {
            $params['cache']['ttl'] = static::TTL;
        }

        return static::getEntity()->getList($params);

The expression return static::getEntity()->getList($params) returns the type null which is incompatible with the type-hinted return Bitrix\Main\ORM\Query\Result.

Are you sure the usage of static::getEntity()->getList($params) targeting Alex19pov31\BitrixHelper\Iblock\IblockElementTable::getList() seems to always return null.

    }

    /**
     * Добавление элемента
     *
     * @param array $data
     * @return AddResult
     */
    public static function add(array $data): AddResult
    {
        return static::getEntity()->add($data);
    }

    /**
     * Обновление элемента
     *
     * @param integer $id
     * @param array $data
     * @return UpdateResult
     */
    public static function update(int $id, array $data): UpdateResult
    {
        return static::getEntity()->update($id, $data);
    }

    /**
     * Удаление элемента по идентификатору
     *
     * @param integer $id
     * @return DeleteResult
     */
    public static function delete(int $id): DeleteResult
    {
        return static::getEntity()->delete($id);
    }

    /**
     * Объект для работы с инфоблоком
     *
     * @return IblockElementTable
     */
    private static function getEntity(): IblockElementTable
    {
        if (!is_null(static::$entity)) {

Since $entity is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $entity to at least protected.

            return static::$entity;
        }

        return static::$entity = new  class (static::getIblockCode()) extends IblockElementTable
        { };
    }
}