Arp\LaminasDoctrine\Service\Connection\ConnectionFactory::create()

Complexity

Conditions	4
Paths	12

Size

Total Lines	26
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function create(array $config, $configuration = null, $eventManager = null): Connection
    {
        $params = array_merge(
            [
                'driverClass'  => $config['driverClass'] ?? Driver::class,
                'wrapperClass' => $config['wrapperClass'] ?? null,
                'pdo'          => $config['pdo'] ?? null,
            ],
            $config['params'] ?? []
        );

        if (!empty($config['platform'])) {
            $platform = null;

The assignment to $platform is dead and can be removed.

        }

        try {
            if (is_string($configuration)) {
                $configuration = $this->configurationManager->getConfiguration($configuration);
            }

            return DriverManager::getConnection($params, $configuration, $eventManager);

It seems like $configuration can also be of type string; however, parameter $config of Doctrine\DBAL\DriverManager::getConnection() does only seem to accept Doctrine\DBAL\Configuration|null, maybe add an additional type check?

It seems like $eventManager can also be of type string; however, parameter $eventManager of Doctrine\DBAL\DriverManager::getConnection() does only seem to accept Doctrine\Common\EventManager|null, maybe add an additional type check?

        } catch (\Throwable $e) {
            throw new ConnectionFactoryException(
                sprintf('Failed to create new connection: %s', $e->getMessage()),
                $e->getCode(),
                $e
            );