Arp\LaminasDoctrine\Query\Filter\Between

Complexity

Total Complexity

4

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	filter()	0	22	4

<?php

declare(strict_types=1);

namespace Arp\LaminasDoctrine\Query\Filter;

use Arp\LaminasDoctrine\Query\Constant\WhereType;
use Arp\LaminasDoctrine\Query\Exception\InvalidArgumentException;
use Arp\LaminasDoctrine\Query\Metadata\MetadataInterface;
use Arp\LaminasDoctrine\Query\QueryBuilderInterface;
use Doctrine\ORM\Query\Expr;

/**
 * @author  Alex Patterson <alex.patterson.webdev@gmail.com>
 * @package Arp\LaminasDoctrine\Query\Filter
 */
final class Between extends AbstractFilter
{
    /**
     * @param QueryBuilderInterface $queryBuilder
     * @param MetadataInterface     $metadata
     * @param array                 $criteria
     *
     * @throws InvalidArgumentException
     */
    public function filter(QueryBuilderInterface $queryBuilder, MetadataInterface $metadata, array $criteria): void
    {
        $fieldName = $this->resolveFieldName($metadata, $criteria);

The call to Arp\LaminasDoctrine\Query\Filter\AbstractFilter::resolveFieldName() has too few arguments starting with key.

Are you sure the assignment to $fieldName is correct as $this->resolveFieldName($metadata, $criteria) targeting Arp\LaminasDoctrine\Query\Filter\AbstractFilter::resolveFieldName() seems to always return null.

        $queryAlias = $criteria['alias'] ?? 'entity';
        $paramName = uniqid($queryAlias, false);

        $expression = $queryBuilder->expr()->between(

The call to Doctrine\ORM\Query\Expr::between() has too few arguments starting with val.

        );

The first argument in a multi-line function call must be on the line after the opening parenthesis

        if (!isset($criteria['where']) || WhereType::AND === $criteria['where']) {
            $queryBuilder->andWhere($expression);
        } else {
            $queryBuilder->orWhere($expression);
        }

        // Some comparisons will not require a value to be provided
        if (array_key_exists('value', $criteria)) {
            $value = $this->formatValue($metadata, $fieldName, $criteria['value'], $criteria['format'] ?? null);

$fieldName of type null is incompatible with the type string expected by parameter $fieldName of Arp\LaminasDoctrine\Query\Filter\AbstractFilter::formatValue().

            $queryBuilder->setParameter($paramName, $value);
        }
    }
}