Arp\EventDispatcher\Factory\EventDispatcherFactory

Complexity

Total Complexity

8

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	createListenerProvider()	0	22	4
A	create()	0	12	3
A	__construct()	0	3	1

<?php

declare(strict_types=1);

namespace Arp\EventDispatcher\Factory;

use Arp\EventDispatcher\EventDispatcher;
use Arp\EventDispatcher\Factory\Listener\ListenerProviderFactory;
use Arp\EventDispatcher\Listener\AddableListenerProviderInterface;
use Arp\Factory\Exception\FactoryException;
use Arp\Factory\FactoryInterface;
use Psr\EventDispatcher\EventDispatcherInterface;
use Psr\EventDispatcher\ListenerProviderInterface;

/**
 * @author  Alex Patterson <alex.patterson.webdev@gmail.com>
 * @package Arp\EventDispatcher\Factory
 */
class EventDispatcherFactory implements FactoryInterface
{
    use ListenerRegistrationTrait;

    /**
     * @var FactoryInterface|null
     */
    private $listenerProviderFactory;

    /**
     * @param FactoryInterface|null $listenerProviderFactory
     */
    public function __construct(?FactoryInterface $listenerProviderFactory = null)
    {
        $this->listenerProviderFactory = $listenerProviderFactory;
    }

    /**
     * Create a new event dispatcher.
     *
     * @param array $config
     *
     * @return EventDispatcherInterface
     *
     * @throws FactoryException
     */
    public function create(array $config = []): EventDispatcherInterface
    {
        $eventDispatcher = new EventDispatcher(
            $this->createListenerProvider($config['listener_provider'] ?? [])
        );

        $listeners = $config['listeners'] ?? [];
        if (!empty($listeners) && $eventDispatcher instanceof AddableListenerProviderInterface) {

$eventDispatcher is never a sub-type of Arp\EventDispatcher\Listener\AddableListenerProviderInterface.

            $this->registerEventListeners($eventDispatcher, $listeners);
        }

        return $eventDispatcher;
    }

    /**
     * Create a new listener provider with the provided configuration options.
     *
     * @param ListenerProviderInterface|array $config
     *
     * @return AddableListenerProviderInterface
     *
     * @throws FactoryException
     */
    private function createListenerProvider($config): AddableListenerProviderInterface
    {
        if ($config instanceof AddableListenerProviderInterface) {
            return $config;
        }

        if (!is_array($config)) {
            throw new FactoryException(
                sprintf(
                    'The listener provider configuration must be of type \'array\'; \'%s\' provided in \'%s\'',
                    gettype($config),
                    __METHOD__
                )
            );
        }

        if (null === $this->listenerProviderFactory) {
            $this->listenerProviderFactory = new ListenerProviderFactory();
        }

        /** @var AddableListenerProviderInterface $listenerProvider */
        return $this->listenerProviderFactory->create($config);

The expression return $this->listenerProviderFactory->create($config) could return the type Psr\EventDispatcher\ListenerProviderInterface which includes types incompatible with the type-hinted return Arp\EventDispatcher\Listener\AddableListenerProviderInterface. Consider adding an additional type-check to rule them out.

    }
}