QueryFilterManagerTest::testFilterApplyArrayFilterCriteria() - Code Metrics - Inspection of "Merge pull request #1 from alex-patterson-webdev/f..." - alex-patterson-webdev/doctrine-query-filter - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( 676de8...b86364 )

by Alex
created 2021-02-14 17:19 UTC
testFilterApplyArrayFilterCriteria() A

↳ Parent: QueryFilterManagerTest
Complexity

Conditions	2
Paths	2
Size

Total Lines	60
Code Lines	34
Duplication

Lines	0
Ratio	0 %
Importance

Changes	2
Bugs	0	Features	0
Metric	Value
eloc	34
c	2
b	0
f	0
dl	0
loc	60
rs	9.376
cc	2
nc	2
nop	0
How to fix Long Method

<?php

declare(strict_types=1);

namespace ArpTest\DoctrineQueryFilter;

use Arp\DoctrineQueryFilter\Exception\QueryFilterManagerException;
use Arp\DoctrineQueryFilter\Filter\Exception\FilterException;
use Arp\DoctrineQueryFilter\Filter\Exception\FilterFactoryException;
use Arp\DoctrineQueryFilter\Filter\FilterFactoryInterface;
use Arp\DoctrineQueryFilter\Filter\FilterInterface;
use Arp\DoctrineQueryFilter\Filter\IsEqual;
use Arp\DoctrineQueryFilter\Filter\IsNotEqual;
use Arp\DoctrineQueryFilter\Metadata\MetadataInterface;
use Arp\DoctrineQueryFilter\QueryBuilderInterface;
use Arp\DoctrineQueryFilter\QueryFilterManager;
use Arp\DoctrineQueryFilter\QueryFilterManagerInterface;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\Mapping\ClassMetadata;
use Doctrine\ORM\QueryBuilder as DoctrineQueryBuilder;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;

/**
 * @covers  \Arp\DoctrineQueryFilter\QueryFilterManager
 *
 * @author  Alex Patterson <[email protected]>
 * @package ArpTest\LaminasDoctrine
 */
final class QueryFilterManagerTest extends TestCase
{
    /**
     * @var FilterFactoryInterface|MockObject
     */
    private $filterFactory;

    /**
     * Prepare the test case dependencies
     */
    public function setUp(): void
    {
        $this->filterFactory = $this->createMock(FilterFactoryInterface::class);
    }

    /**
     * Assert that the manager implements QueryFilterManagerInterface
     */
    public function testImplementsQueryFilterManagerInterface(): void
    {
        $manager = new QueryFilterManager($this->filterFactory);

        $this->assertInstanceOf(QueryFilterManagerInterface::class, $manager);
    }

    /**
     * Assert no filtering will be applied if filter() is provided configuration without the required 'filters' key
     *
     * @throws QueryFilterManagerException
     */
    public function testFilterWillNotPerformFilteringWithoutFilterKey(): void
    {
        $manager = new QueryFilterManager($this->filterFactory);

        /** @var QueryBuilderInterface|MockObject $queryBuilder */
        $queryBuilder = $this->createMock(QueryBuilderInterface::class);

        $queryBuilder->expects($this->never())->method('getEntityManager');

        $this->assertSame($queryBuilder, $manager->filter($queryBuilder, 'Foo', []));
    }

    /**
     * Assert that failure to create a entity metadata instance will result in a
     * QueryFilterManagerException being thrown
     *
     * @throws QueryFilterManagerException
     */
    public function testFilterWillThrowQueryFilterManagerExceptionIfProvidedWithAnInvalidEntityName(): void
    {
        $entityName = 'Test';
        $manager = new QueryFilterManager($this->filterFactory);

        $criteria = [
            'filters' => [
                [
                    'name' => 'foo',
                ],
            ],
        ];

        /** @var DoctrineQueryBuilder|MockObject $queryBuilder */
        $queryBuilder = $this->createMock(DoctrineQueryBuilder::class);

        /** @var EntityManager|MockObject $entityManager */
        $entityManager = $this->createMock(EntityManager::class);

        $queryBuilder->expects($this->once())
            ->method('getEntityManager')
            ->willReturn($entityManager);

        $exceptionMessage = 'This is an exception message';
        $exceptionCode = 123;
        $exception = new \Exception($exceptionMessage, $exceptionCode);

        $entityManager->expects($this->once())
            ->method('getClassMetadata')
            ->with($entityName)
            ->willThrowException($exception);

        $this->expectException(QueryFilterManagerException::class);
        $this->expectExceptionCode($exceptionCode);
        $this->expectExceptionMessage(
            sprintf('Failed to fetch entity metadata for class \'%s\': %s', $entityName, $exceptionMessage),
        );

        $manager->filter($queryBuilder, $entityName, $criteria);
    }

    /**
     * Assert that a QueryFilterManagerException is thrown if providing an invalid QueryBuilder instance to filter()
     *
     * @throws QueryFilterManagerException
     */
    public function testQueryFilterManagerExceptionIsThrownWhenProvidingAnInvalidQueryBuilderToFilter(): void
    {
        $manager = new QueryFilterManager($this->filterFactory);

        $invalidQueryBuilder = new \stdClass();
        $entityName = 'EntityTestName';
        $criteria = [];

        $this->expectException(QueryFilterManagerException::class);
        $this->expectExceptionMessage(
            sprintf(
                'The \'queryBuilder\' argument must be an object of type \'%s\' or \'%s\'; '
                . '\'%s\' provided in \'%s\'',
                QueryBuilderInterface::class,
                DoctrineQueryBuilder::class,
                is_object($invalidQueryBuilder) ? get_class($invalidQueryBuilder) : gettype($invalidQueryBuilder),
                QueryFilterManager::class
            )
        );

        /** @noinspection PhpParamsInspection */
        $manager->filter($invalidQueryBuilder, $entityName, $criteria);
        $manager->filter(/** @scrutinizer ignore-type */ $invalidQueryBuilder, $entityName, $criteria);
    }

    /**
     * Assert that a QueryFilterManagerException if thrown when providing an array query filter specification that
     * does not contain a 'name' property
     *
     * @throws QueryFilterManagerException
     */
    public function testMissingFilterNameWillThrowQueryFilterManagerException(): void
    {
        $manager = new QueryFilterManager($this->filterFactory);

        /** @var QueryBuilderInterface|MockObject $queryBuilder */
        $queryBuilder = $this->createMock(QueryBuilderInterface::class);

        $entityName = 'TestClass';
        $criteria = [
            'filters' => [
                [],
            ],
        ];

        /** @var EntityManager|MockObject $entityManager */
        $entityManager = $this->createMock(EntityManager::class);

        $queryBuilder->expects($this->once())
            ->method('getEntityManager')
            ->willReturn($entityManager);

        /** @var ClassMetadata|MockObject $metadata */
        $metadata = $this->createMock(ClassMetadata::class);

        $entityManager->expects($this->once())
            ->method('getClassMetadata')
            ->with($entityName)
            ->willReturn($metadata);

        $this->expectException(QueryFilterManagerException::class);
        $this->expectExceptionMessage(
            sprintf('The required \'name\' configuration option is missing in \'%s\'', QueryFilterManager::class)
        );

        $manager->filter($queryBuilder, $entityName, $criteria);
    }

    /**
     * Assert that a QueryFilterManagerException if thrown when providing invalid criteria filters to filter()
     *
     * @throws QueryFilterManagerException
     */
    public function testInvalidFilterWillThrowQueryFilterManagerException(): void
    {
        $manager = new QueryFilterManager($this->filterFactory);

        /** @var QueryBuilderInterface|MockObject $queryBuilder */
        $queryBuilder = $this->createMock(QueryBuilderInterface::class);

        $filter = new \stdClass();
        $entityName = 'TestClass';
        $criteria = [
            'filters' => [
                $filter,
            ],
        ];

        /** @var EntityManager|MockObject $entityManager */
        $entityManager = $this->createMock(EntityManager::class);

        $queryBuilder->expects($this->once())
            ->method('getEntityManager')
            ->willReturn($entityManager);

        /** @var ClassMetadata|MockObject $metadata */
        $metadata = $this->createMock(ClassMetadata::class);

        $entityManager->expects($this->once())
            ->method('getClassMetadata')
            ->with($entityName)
            ->willReturn($metadata);

        $this->expectException(QueryFilterManagerException::class);
        $this->expectExceptionMessage(
            sprintf(
                'The \'data\' argument must be an \'array\' or object of type \'%s\'; \'%s\' provided in \'%s\'',
                FilterInterface::class,
                is_object($filter) ? get_class($filter) : gettype($filter),
                QueryFilterManager::class
            )
        );

        $manager->filter($queryBuilder, $entityName, $criteria);
    }

    /**
     * Assert that a QueryFilterManagerException is thrown when unable to apply the filters in applyFilter().
     *
     * @throws QueryFilterManagerException
     */
    public function testFailureToApplyFilterWillResultInQueryFilterManagerException(): void
    {
        /** @var FilterInterface[]|MockObject[] $filters */
        $filters = [
            $this->createMock(FilterInterface::class),
            $this->createMock(FilterInterface::class),
        ];

        $manager = new QueryFilterManager($this->filterFactory);

        /** @var QueryBuilderInterface|MockObject $queryBuilder */
        $queryBuilder = $this->createMock(QueryBuilderInterface::class);

        $entityName = 'TestClass';
        $criteria = [
            'filters' => $filters,
        ];

        /** @var EntityManager|MockObject $entityManager */
        $entityManager = $this->createMock(EntityManager::class);

        $queryBuilder->expects($this->once())
            ->method('getEntityManager')
            ->willReturn($entityManager);

        /** @var ClassMetadata|MockObject $metadata */
        $metadata = $this->createMock(ClassMetadata::class);

        $entityManager->expects($this->once())
            ->method('getClassMetadata')
            ->with($entityName)
            ->willReturn($metadata);

        $exceptionMessage = 'This is a test filter exception message';
        $exceptionCode = 999;
        $filterException = new FilterException($exceptionMessage, $exceptionCode);

        $filters[0]->expects($this->once())
            ->method('filter')
            ->with($queryBuilder, $this->isInstanceOf(MetadataInterface::class), [])
            ->willThrowException($filterException);

        $metadata->expects($this->once())
            ->method('getName')
            ->willReturn($entityName);

        $this->expectException(QueryFilterManagerException::class);
        $this->expectExceptionCode($exceptionCode);
        $this->expectExceptionMessage(
            sprintf('Failed to apply query filter for entity \'%s\': %s', $entityName, $exceptionMessage)
        );

        $manager->filter($queryBuilder, $entityName, $criteria);
    }

    /**
     * Assert that the expected $criteria filters will be applyed when calling filter()
     *
     * @throws QueryFilterManagerException
     */
    public function testFilterApplyArrayFilterCriteria(): void
    {
        $filterData = [
            [
                'name'  => IsEqual::class,
                'field' => 'test',
                'value' => 123,
            ],
            [
                'name'  => IsNotEqual::class,
                'field' => 'test2',
                'value' => 'Hello World!',
            ],
        ];

        $manager = new QueryFilterManager($this->filterFactory);

        /** @var QueryBuilderInterface|MockObject $queryBuilder */
        $queryBuilder = $this->createMock(QueryBuilderInterface::class);

        $entityName = 'TestClass';
        $criteria = [
            'filters' => $filterData,
        ];

        /** @var EntityManager|MockObject $entityManager */
        $entityManager = $this->createMock(EntityManager::class);

        $queryBuilder->expects($this->once())
            ->method('getEntityManager')
            ->willReturn($entityManager);

        /** @var ClassMetadata|MockObject $metadata */
        $metadata = $this->createMock(ClassMetadata::class);

        $entityManager->expects($this->once())
            ->method('getClassMetadata')
            ->with($entityName)
            ->willReturn($metadata);

        $factoryArgs = $createdFilters = [];
        foreach ($filterData as $data) {
            /** @var FilterInterface|MockObject $createdFilter */
            $createdFilter = $this->createMock(FilterInterface::class);

            $factoryArgs[] = [$manager, $data['name'], $data['options'] ?? []];

            $createdFilter->expects($this->once())
                ->method('filter')
                ->with($queryBuilder, $this->isInstanceOf(MetadataInterface::class), $data);

            $createdFilters[] = $createdFilter;
        }

        $this->filterFactory->expects($this->exactly(count($filterData)))
            ->method('create')
            ->withConsecutive(...$factoryArgs)
            ->willReturnOnConsecutiveCalls(...$createdFilters);

        $manager->filter($queryBuilder, $entityName, $criteria);
    }

    /**
     * Assert that a QueryFilterManagerException is thrown when createFilter is unable to create $name
     *
     * @throws QueryFilterManagerException
     */
    public function testCreateFilterThrowsQueryFilterManagerExceptionIfUnableToCreateFilter(): void
    {
        $manager = new QueryFilterManager($this->filterFactory);

        $name = 'FooFilterName';
        $options = [
            'foo' => 123,
            'bar' => true,
        ];

        $exceptionMessage = 'This is a test exception message';
        $exceptionCode = 123;
        $exception = new FilterFactoryException($exceptionMessage, $exceptionCode);

        $this->filterFactory->expects($this->once())
            ->method('create')
            ->with($manager, $name, $options)
            ->willThrowException($exception);

        $this->expectException(QueryFilterManagerException::class);
        $this->expectExceptionCode($exceptionCode);
        $this->expectExceptionMessage(
            sprintf('Failed to create filter \'%s\': %s', $name, $exceptionMessage)
        );

        $manager->createFilter($name, $options);
    }
}

alex-patterson-webdev / doctrine-query-filter

Push — master ( 676de8...b86364 )

testFilterApplyArrayFilterCriteria() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
