DeeperVin::getByCode() - Code Metrics - Inspection of "simple-vin manufacturers tests" - alex-kalanis/simple-vin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 97e252...64a533 )

by Petr

created 2024-12-21 10:28 UTC

DeeperVin::getByCode() A

↳ Parent: DeeperVin

Complexity

Conditions	5
Paths	3

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	5

Importance

Changes

Metric	Value
cc	5
eloc	5
c	0
b	0
f	0
nc	3
nop	1
dl	0
loc	9
ccs	6
cts	6
cp	1
crap	5
rs	9.6111

<?php

namespace kalanis\simple_vin;


use kalanis\simple_vin\Support\Manufacturer;
use Psr\Clock\ClockInterface;


/**
 * Extended class for accessing VIN data
 */
class DeeperVin
{
    protected readonly SimpleVin $simple;
    protected readonly Datasources\WorldManufacturerClasses $worldManufacturerIdentifiers;

    public function __construct(
        ?ClockInterface $clock = null,
    )
    {
        // no DI
        $this->simple = new SimpleVin($clock);

        $this->worldManufacturerIdentifiers = new Datasources\WorldManufacturerClasses();

    }

    /**
     * @param string $vinOrWmi
     * @return Manufacturer[]
     */
    public function getPossibleManufacturers(string $vinOrWmi): array
    {
        if (!$this->simple->isValid($vinOrWmi)) {
            return [];
        }

        return $this->filterByYears(
            $this->simple->getModelYear($vinOrWmi),
            $this->getByCode($vinOrWmi)
        );
    }

    /**
     * @param string $code
     * @return Manufacturer[]
     */
    protected function getByCode(string $code): array
    {
        $used = [];
        foreach ($this->worldManufacturerIdentifiers as $item) {
            if (is_object($item) && is_a($item, Manufacturer::class) && str_starts_with($code, $item->code)) {
                $used[] = $item;
            }
        }
        return $used;
    }

    /**
     * Years matters only for americans
     * @param int|null $year
     * @param Manufacturer[] $availableManufacturers
     * @return Manufacturer[]
     */
    protected function filterByYears(?int $year, array $availableManufacturers): array
    {
        if (is_null($year)) {
            return $this->filterLongest($availableManufacturers);
        }

        // years from
        $passedFrom = [];
        foreach ($availableManufacturers as $availableManufacturer) {
            if (!$availableManufacturer->canCompareDates) {
                $passedFrom[] = $availableManufacturer;
                continue;
            }
            if (is_null($availableManufacturer->from) || ($availableManufacturer->from <= $year)) {
                $passedFrom[] = $availableManufacturer;
            }
        }

        // years to
        $passedTo = [];
        foreach ($passedFrom as $availableManufacturer) {
            if (!$availableManufacturer->canCompareDates) {
                $passedTo[] = $availableManufacturer;
                continue;
            }
            if (is_null($availableManufacturer->to) || ($availableManufacturer->to >= $year)) {
                $passedTo[] = $availableManufacturer;
            }
        }

        return $this->filterLongest($passedTo);
    }

    /**
     * @param Manufacturer[] $entries
     * @return Manufacturer[]
     */
    protected function filterLongest(array $entries): array
    {
        $longestCodeLen = 0;
        foreach ($entries as $item) {
            $longestCodeLen = max($longestCodeLen, strlen($item->code));
        }
        $onlyLongest = [];
        foreach ($entries as $item) {
            if (strlen($item->code) == $longestCodeLen) {
                $onlyLongest[] = $item;
            }
        }

        return $onlyLongest;
    }
}


1		<?php
2
3		namespace kalanis\simple_vin;
4
5
6		use kalanis\simple_vin\Support\Manufacturer;
7		use Psr\Clock\ClockInterface;
8
9
10		/**
11		* Extended class for accessing VIN data
12		*/
13		class DeeperVin
14		{
15		protected readonly SimpleVin $simple;
16		protected readonly Datasources\WorldManufacturerClasses $worldManufacturerIdentifiers;
17
18	7	public function __construct(
19		?ClockInterface $clock = null,
20		)
21		{
22		// no DI
23	7	$this->simple = new SimpleVin($clock);
		0 ignored issues – show Bug introduced 2024-12-21 10:41 UTC by Report Bug Copy Issue Report The property `simple` is declared read-only in `kalanis\simple_vin\DeeperVin`. Loading history...
24	7	$this->worldManufacturerIdentifiers = new Datasources\WorldManufacturerClasses();
		0 ignored issues – show Bug introduced 2024-12-21 10:41 UTC by Report Bug Copy Issue Report The property `worldManufacturerIdentifiers` is declared read-only in `kalanis\simple_vin\DeeperVin`. Loading history...
25		}
26
27		/**
28		* @param string $vinOrWmi
29		* @return Manufacturer[]
30		*/
31	7	public function getPossibleManufacturers(string $vinOrWmi): array
32		{
33	7	if (!$this->simple->isValid($vinOrWmi)) {
34	1	return [];
35		}
36
37	6	return $this->filterByYears(
38	6	$this->simple->getModelYear($vinOrWmi),
39	6	$this->getByCode($vinOrWmi)
40	6	);
41		}
42
43		/**
44		* @param string $code
45		* @return Manufacturer[]
46		*/
47	6	protected function getByCode(string $code): array
48		{
49	6	$used = [];
50	6	foreach ($this->worldManufacturerIdentifiers as $item) {
51	6	if (is_object($item) && is_a($item, Manufacturer::class) && str_starts_with($code, $item->code)) {
52	6	$used[] = $item;
53		}
54		}
55	6	return $used;
56		}
57
58		/**
59		* Years matters only for americans
60		* @param int\|null $year
61		* @param Manufacturer[] $availableManufacturers
62		* @return Manufacturer[]
63		*/
64	6	protected function filterByYears(?int $year, array $availableManufacturers): array
65		{
66	6	if (is_null($year)) {
67	2	return $this->filterLongest($availableManufacturers);
68		}
69
70		// years from
71	4	$passedFrom = [];
72	4	foreach ($availableManufacturers as $availableManufacturer) {
73	4	if (!$availableManufacturer->canCompareDates) {
74	3	$passedFrom[] = $availableManufacturer;
75	3	continue;
76		}
77	2	if (is_null($availableManufacturer->from) \|\| ($availableManufacturer->from <= $year)) {
78	2	$passedFrom[] = $availableManufacturer;
79		}
80		}
81
82		// years to
83	4	$passedTo = [];
84	4	foreach ($passedFrom as $availableManufacturer) {
85	4	if (!$availableManufacturer->canCompareDates) {
86	3	$passedTo[] = $availableManufacturer;
87	3	continue;
88		}
89	2	if (is_null($availableManufacturer->to) \|\| ($availableManufacturer->to >= $year)) {
90	1	$passedTo[] = $availableManufacturer;
91		}
92		}
93
94	4	return $this->filterLongest($passedTo);
95		}
96
97		/**
98		* @param Manufacturer[] $entries
99		* @return Manufacturer[]
100		*/
101	6	protected function filterLongest(array $entries): array
102		{
103	6	$longestCodeLen = 0;
104	6	foreach ($entries as $item) {
105	5	$longestCodeLen = max($longestCodeLen, strlen($item->code));
106		}
107	6	$onlyLongest = [];
108	6	foreach ($entries as $item) {
109	5	if (strlen($item->code) == $longestCodeLen) {
110	5	$onlyLongest[] = $item;
111		}
112		}
113
114	6	return $onlyLongest;
115		}
116		}
117

alex-kalanis / simple-vin

Push — master ( 97e252...64a533 )

DeeperVin::getByCode() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like