alex-kalanis / pohoda

src/Pohoda/Common/AddParameterTrait.php

<?php

/**
 * This file is part of riesenia/pohoda package.
 *
 * Licensed under the MIT License
 * (c) RIESENIA.com
 */

declare(strict_types=1);

namespace Riesenia\Pohoda\Common;

use Riesenia\Pohoda\Type\Parameter;

/**
 * @property array{
 *     parameters?: iterable<Parameter>
 * } $data
 */
trait AddParameterTrait
{
    /**
     * Set user-defined parameter.
     *
     * @param string     $name  (can be set without preceding VPr / RefVPr)
     * @param string     $type
     * @param mixed      $value
     * @param mixed|null $list
     * @return self
     */
    public function addParameter(string $name, string $type, mixed $value, mixed $list = null): self
    {
        if (!isset($this->data['parameters'])
            || !(
                is_array($this->data['parameters'])
                || (is_a($this->data['parameters'], \ArrayAccess::class))
            )
        ) {
            $this->data['parameters'] = [];

The property data does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }

        $parameter = new Parameter(
            $this->namespacesPaths,
            $this->sanitizeEncoding,
            $this->normalizerFactory,
        );
        $parameter
            ->setDirectionalVariable($this->useOneDirectionalVariables)
            ->setResolveOptions($this->resolveOptions)
            ->setData([
                'name' => $name,
                'type' => $type,
                'value' => $value,
                'list' => $list,
            ]);
        $this->data['parameters'][] = $parameter;

        return $this;
    }
}