tests\ChecksTests\TraitsTests\ToLocalFileTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testNone2()	0	7	1
A	testResource()	0	9	1
A	testNone1()	0	7	1
A	testString()	0	11	1

<?php

namespace tests\ChecksTests\TraitsTests;


use tests\CommonTestClass;
use kalanis\kw_mime\MimeException;


class ToLocalFileTest extends CommonTestClass
{
    /**
     * @throws MimeException
     */
    public function testNone1(): void
    {
        $lib = new XToLocalFile();
        $lib->initTempFile();
        @unlink($lib->getTempFile());

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

        $this->expectException(MimeException::class);
        $lib->convert('file', /** @scrutinizer ignore-type */ false);
    }

    /**
     * @throws MimeException
     */
    public function testNone2(): void
    {
        $lib = new XToLocalFile();
        $lib->initTempFile();
        @unlink($lib->getTempFile());

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

        $this->expectException(MimeException::class);
        $lib->convert('file', /** @scrutinizer ignore-type */ null);
    }

    /**
     * @throws MimeException
     */
    public function testString(): void
    {
        $lib = new XToLocalFile();
        $lib->initTempFile();
        $pt1 = $lib->convert('data', 'test data');
        $this->assertEquals('test data', file_get_contents($pt1));
        @unlink($pt1);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

        $lib->initTempFile();
        $pt2 = $lib->convert('nums', /** @scrutinizer ignore-type */ 123456);
        $this->assertEquals('123456', file_get_contents($pt2));
        @unlink($pt2);
    }

    /**
     * @throws MimeException
     */
    public function testResource(): void
    {
        $lib = new XToLocalFile();
        $res = @fopen('php://memory', 'r+');
        fwrite($res, 'okmijnuhb');

It seems like $res can also be of type false; however, parameter $stream of fwrite() does only seem to accept resource, maybe add an additional type check?

        $lib->initTempFile();
        $pt1 = $lib->convert('res', $res);

It seems like $res can also be of type false; however, parameter $content of tests\ChecksTests\TraitsTests\XToLocalFile::convert() does only seem to accept resource|string, maybe add an additional type check?

        $this->assertEquals('okmijnuhb', file_get_contents($pt1));
        @unlink($pt1);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

    }
}