kalanis\kw_coordinates\Codecs\Passing

Complexity

Total Complexity

11

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	toLonLat()	0	6	4
A	fromLonLat()	0	6	4
A	__construct()	0	4	3

<?php

namespace kalanis\kw_coordinates\Codecs;


use kalanis\kw_coordinates\Interfaces;
use kalanis\kw_coordinates\Support;


/**
 * Class Passing
 * @package kalanis\kw_coordinates\Codecs
 * Just pass through
 * Good when you convert between more codecs and one of them is the basic format
 */
class Passing implements Interfaces\ICodecs
{
    /** @var Interfaces\INumbers */
    protected $pos = null;
    /** @var Interfaces\IFormatted */
    protected $out = null;

    public function __construct(?Interfaces\INumbers $position = null, ?Interfaces\IFormatted $output = null)
    {
        $this->pos = $position ?: new Support\Position();
        $this->out = $output ?: new Support\DegreesObject();
    }

    public function fromLonLat(Interfaces\INumbers $position): Interfaces\IFormatted
    {
        return (clone $this->out)->setData(
            is_null($position->getLongitude()) ? null : strval($position->getLongitude()),

The condition is_null($position->getLongitude()) is always false.

            is_null($position->getLatitude()) ? null : strval($position->getLatitude()),

The condition is_null($position->getLatitude()) is always false.

            is_null($position->getAltitude()) ? null : strval($position->getAltitude()),

The condition is_null($position->getAltitude()) is always false.

        );
    }

    public function toLonLat(Interfaces\IFormatted $source): Interfaces\INumbers
    {
        return (clone $this->pos)->setData(
            is_null($source->getLongitude()) ? null : floatval(strval($source->getLongitude())),

It seems like is_null($source->getLongitude()) ? null : floatval(strval($source->getLongitude())) can also be of type null; however, parameter $longitude of kalanis\kw_coordinates\Interfaces\INumbers::setData() does only seem to accept double, maybe add an additional type check?

            is_null($source->getLatitude()) ? null : floatval(strval($source->getLatitude())),

It seems like is_null($source->getLatitude()) ? null : floatval(strval($source->getLatitude())) can also be of type null; however, parameter $latitude of kalanis\kw_coordinates\Interfaces\INumbers::setData() does only seem to accept double, maybe add an additional type check?

            is_null($source->getAltitude()) ? null : floatval(strval($source->getAltitude()))

It seems like is_null($source->getAltitude()) ? null : floatval(strval($source->getAltitude())) can also be of type null; however, parameter $altitude of kalanis\kw_coordinates\Interfaces\INumbers::setData() does only seem to accept double, maybe add an additional type check?

        );
    }
}