StorageTests\AStorageTest

Complexity

Total Complexity

1

Size/Duplication

Total Lines	11
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getStorage()	0	5	1

<?php

namespace StorageTests;


use kalanis\kw_storage\Interfaces\IStorage;
use kalanis\kw_storage\Storage as XStorage;


abstract class AStorageTest extends \CommonTestClass
{
    /**
     * @param IStorage|string $mockStorage
     * @return XStorage\Storage
     */
    protected function getStorage($mockStorage): XStorage\Storage
    {
        XStorage\Key\DirKey::setDir(__DIR__ . DIRECTORY_SEPARATOR . '..' . DIRECTORY_SEPARATOR . 'data' . DIRECTORY_SEPARATOR);
        $storage = new XStorage\Factory(new XStorage\Key\Factory(), new XStorage\Target\Factory());
        return $storage->getStorage($mockStorage);

The expression return $storage->getStorage($mockStorage) could return the type null which is incompatible with the type-hinted return kalanis\kw_storage\Storage\Storage. Consider adding an additional type-check to rule them out.

    }
}