JsonHttpSerializer::deserialize() - Code Metrics - Inspection of "Merge pull request #1 from alex-foleon/001-basic" - alex-foleon/service-library-catalog-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — main (4cb13d)

by Mr.

created 2020-12-24 15:19 UTC

JsonHttpSerializer::deserialize() A

↳ Parent: JsonHttpSerializer

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3.0261

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	7
c	1
b	0
f	0
nc	3
nop	1
dl	0
loc	11
ccs	6
cts	7
cp	0.8571
crap	3.0261
rs	10

<?php

declare(strict_types=1);

namespace LibraryCatalog\Transformer;

use LibraryCatalog\Exception\HttpBadRequestException;
use LibraryCatalog\Transformer\Encoder\EncoderInterface;

class JsonHttpSerializer implements HttpSerializerInterface
{
    /** @var EncoderInterface */
    protected $encoder;

    /**
     * Serializer constructor.
     * @param EncoderInterface $encoder
     */
    public function __construct(EncoderInterface $encoder)
    {
        $this->encoder = $encoder;
    }

    /**
     * @param $data
     * @return string
     * @throws Encoder\Exception
     */
    public function serialize($data): string
    {
        return $this->encoder->encode($data);
    }

    /**
     * Should deserialize HTTP RAW data to array.
     *
     * @param string $data
     * @return array
     * @throws HttpBadRequestException
     */
    public function deserialize(string $data): array
    {
        try {
            $res = $this->encoder->decode($data);
        } catch (\Exception $e) {
            throw new HttpBadRequestException('Bad request, can not json-decode input data');
        }
        if (!is_array($res)) {
            throw new HttpBadRequestException('Bad request, can not json-decode input data');
        }
        return $res;
    }

    /**
     * @return array
     */
    public function getResponseHeaders(): array
    {
        return ['Content-Type' => 'application/json'];
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace LibraryCatalog\Transformer;
6
7		use LibraryCatalog\Exception\HttpBadRequestException;
8		use LibraryCatalog\Transformer\Encoder\EncoderInterface;
9
10		class JsonHttpSerializer implements HttpSerializerInterface
11		{
12		/** @var EncoderInterface */
13		protected $encoder;
14
15		/**
16		* Serializer constructor.
17		* @param EncoderInterface $encoder
18		*/
19	2	public function __construct(EncoderInterface $encoder)
20		{
21	2	$this->encoder = $encoder;
22	2	}
23
24		/**
25		* @param $data
26		* @return string
27		* @throws Encoder\Exception
28		*/
29	17	public function serialize($data): string
30		{
31	17	return $this->encoder->encode($data);
32		}
33
34		/**
35		* Should deserialize HTTP RAW data to array.
36		*
37		* @param string $data
38		* @return array
39		* @throws HttpBadRequestException
40		*/
41	7	public function deserialize(string $data): array
42		{
43		try {
44	7	$res = $this->encoder->decode($data);
45	1	} catch (\Exception $e) {
46	1	throw new HttpBadRequestException('Bad request, can not json-decode input data');
47		}
48	6	if (!is_array($res)) {
49		throw new HttpBadRequestException('Bad request, can not json-decode input data');
50		}
51	6	return $res;
52		}
53
54		/**
55		* @return array
56		*/
57	1	public function getResponseHeaders(): array
58		{
59	1	return ['Content-Type' => 'application/json'];
60		}
61		}
62

alex-foleon / service-library-catalog-php

Branch — main (4cb13d)

JsonHttpSerializer::deserialize() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like