LibraryCatalog\Infrastructure\Persistence\BookRepositoryPdo

Complexity

Total Complexity

7

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Test Coverage

Coverage

94.12%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	loadByAuthorId()	0	8	2
A	load()	0	8	3
A	save()	0	3	1
A	__construct()	0	4	1

<?php

declare(strict_types=1);

namespace LibraryCatalog\Infrastructure\Persistence;

use LibraryCatalog\Entity\Book;
use LibraryCatalog\Service\Repository\BookRepositoryInterface;
use LibraryCatalog\Service\Repository\Exception;
use LibraryCatalog\Service\Repository\PdoTrait;
use LibraryCatalog\Transformer\Serializer;

class BookRepositoryPdo implements BookRepositoryInterface
{
    use PdoTrait;

    protected const TABLE_NAME = 'books';
    protected const LIMIT_BOOKS = 5000;

    /** @var Serializer */
    protected Serializer $serializer;

    /**
     * BookRepositoryPdo constructor.
     * @param Serializer $serializer
     * @param string $host
     * @param string $user
     * @param string $password
     * @param string $dbname
     */
    public function __construct(Serializer $serializer, string $host, string $user, string $password, string $dbname)
    {
        $this->prepareConnection($host, $user, $password, $dbname);
        $this->serializer = $serializer;
    }

    /**
     * @param mixed $id
     * @param bool $withAuthor
     * @return Book|null
     * @throws Exception
     * @throws Serializer\HydrateException
     */
    public function load($id, bool $withAuthor = false): ?Book
    {
        if ($id == '') {
            return null;
        }

        $data = $this->fetchOne(static::TABLE_NAME, $id);
        return $data ? $this->serializer->hydrate($data, Book::class) : null;

The expression return $data ? $this->serializer->hydrate($data, LibraryCatalog\Entity\Book::class) : null could return the type array which is incompatible with the type-hinted return LibraryCatalog\Entity\Book|null. Consider adding an additional type-check to rule them out.

    }

    /**
     * @param mixed $authorId
     * @return Book[]
     * @throws Exception
     * @throws Serializer\HydrateException
     */
    public function loadByAuthorId($authorId): array
    {
        $data = $this->fetchList(static::TABLE_NAME, 'authorId = ?', [$authorId], self::LIMIT_BOOKS, 'title');
        $rows = [];
        foreach ($data as $row) {
            $rows[] = $this->serializer->hydrate($row, Book::class);
        }
        return $rows;
    }

    /**
     * @param Book $book
     * @throws Exception
     */
    public function save(Book $book): void
    {
        $book->id = $this->insert(static::TABLE_NAME, $this->serializer->extractFields($book));
    }
}