LibraryCatalog\Infrastructure\Persistence\AuthorRepositoryPdo

Complexity

Total Complexity

7

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Test Coverage

Coverage

92.86%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	load()	0	8	3
A	loadByNameBirthdate()	0	4	2
A	__construct()	0	4	1
A	save()	0	3	1

<?php

declare(strict_types=1);

namespace LibraryCatalog\Infrastructure\Persistence;

use LibraryCatalog\Entity\Author;
use LibraryCatalog\Service\Repository\AuthorRepositoryInterface;
use LibraryCatalog\Service\Repository\Exception;
use LibraryCatalog\Service\Repository\PdoTrait;
use LibraryCatalog\Transformer\Serializer;

class AuthorRepositoryPdo implements AuthorRepositoryInterface
{
    use PdoTrait;

    protected const TABLE_NAME = 'authors';

    /** @var Serializer */
    protected Serializer $serializer;

    /**
     * AuthorRepositoryPdo constructor.
     * @param Serializer $serializer
     * @param string $host
     * @param string $user
     * @param string $password
     * @param string $dbname
     */
    public function __construct(Serializer $serializer, string $host, string $user, string $password, string $dbname)
    {
        $this->prepareConnection($host, $user, $password, $dbname);
        $this->serializer = $serializer;
    }

    /**
     * @param mixed $id
     * @param bool $withBooks
     * @return Author|null
     * @throws Exception
     * @throws Serializer\HydrateException
     */
    public function load($id, bool $withBooks = false): ?Author
    {
        if ($id == '') {
            return null;
        }

        $data = $this->fetchOne(static::TABLE_NAME, $id);
        return $data ? $this->serializer->hydrate($data, Author::class) : null;

The expression return $data ? $this->serializer->hydrate($data, LibraryCatalog\Entity\Author::class) : null could return the type array which is incompatible with the type-hinted return LibraryCatalog\Entity\Author|null. Consider adding an additional type-check to rule them out.

    }

    /**
     * @param string $name
     * @param string $birthdate
     * @return Author|null
     * @throws Exception
     * @throws Serializer\HydrateException
     */
    public function loadByNameBirthdate(string $name, string $birthdate): ?Author
    {
        $data = $this->fetchList(static::TABLE_NAME, 'name = ? and birthdate = ?', [$name, $birthdate], 1);
        return count($data) >= 1 ? $this->serializer->hydrate($data[0], Author::class) : null;

The expression return count($data) >= 1 ? $this->serializer->hydrate($data[0], LibraryCatalog\Entity\Author::class) : null could return the type array which is incompatible with the type-hinted return LibraryCatalog\Entity\Author|null. Consider adding an additional type-check to rule them out.

    }

    /**
     * @param Author $author
     * @return void
     * @throws Exception
     */
    public function save(Author $author): void
    {
        $author->id = $this->insert(static::TABLE_NAME, $this->serializer->extractFields($author));
    }
}