LibraryCatalog\Service\Catalogue

Complexity

Total Complexity

15

Size/Duplication

Total Lines	84
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	fetchAuthor()	0	12	5
A	fetchBook()	0	12	5
A	getAuthorRepository()	0	3	1
A	__construct()	0	6	1
A	createBook()	0	6	2
A	createAuthor()	0	3	1

<?php

declare(strict_types=1);

namespace LibraryCatalog\Service;

use LibraryCatalog\Entity\Author;
use LibraryCatalog\Entity\Book;
use LibraryCatalog\Service\Repository\AuthorRepositoryInterface;
use LibraryCatalog\Service\Repository\BookRepositoryInterface;
use LibraryCatalog\Service\Repository\WarmRepositoryInterface;

class Catalogue
{
    /** @var AuthorRepositoryInterface */
    protected AuthorRepositoryInterface $authorRepository;
    /** @var BookRepositoryInterface */
    protected BookRepositoryInterface $bookRepository;

    /**
     * Catalogue constructor.
     * @param AuthorRepositoryInterface $authorRepository
     * @param BookRepositoryInterface $bookRepository
     */
    public function __construct(
        AuthorRepositoryInterface $authorRepository,
        BookRepositoryInterface $bookRepository
    ) {
        $this->authorRepository = $authorRepository;
        $this->bookRepository = $bookRepository;
    }

    /**
     * @param $id
     * @param bool $withBooks
     * @return Author|null
     */
    public function fetchAuthor($id, bool $withBooks = false): ?Author
    {
        $author = $this->authorRepository->load($id, $withBooks);
        if ($author && $withBooks && !$author->areBooksLoaded()) {
            // Load and set books for Author.
            $author->setBooks($this->bookRepository->loadByAuthorId($author->id));
            if ($this->authorRepository instanceof WarmRepositoryInterface) {
                // We can warm cache-repository with books.
                $this->authorRepository->warm($author);

The method warm() does not exist on LibraryCatalog\Service\Repository\AuthorRepositoryInterface. It seems like you code against a sub-type of LibraryCatalog\Service\Repository\AuthorRepositoryInterface such as LibraryCatalog\Infrastructure\Persistence\AuthorRepositoryRedis.

            }
        }
        return $author;
    }

    /**
     * @param Author $author
     */
    public function createAuthor(Author $author): void
    {
        $this->authorRepository->save($author);
    }

    /**
     * @param $id
     * @param bool $withAuthor
     * @return Book|null
     */
    public function fetchBook($id, bool $withAuthor = false): ?Book
    {
        $book = $this->bookRepository->load($id, true);
        if ($book && $withAuthor && !$book->isAuthorLoaded()) {
            // Load and set author for book.
            $book->setAuthor($this->authorRepository->load($book->authorId));

It seems like $this->authorRepository->load($book->authorId) can also be of type null; however, parameter $author of LibraryCatalog\Entity\Book::setAuthor() does only seem to accept LibraryCatalog\Entity\Author, maybe add an additional type check?

            if ($this->bookRepository instanceof WarmRepositoryInterface) {
                // We can warm cache-repository with author.
                $this->bookRepository->warm($book);

The method warm() does not exist on LibraryCatalog\Service\Repository\BookRepositoryInterface. It seems like you code against a sub-type of LibraryCatalog\Service\Repository\BookRepositoryInterface such as LibraryCatalog\Infrastructure\Persistence\BookRepositoryRedis.

            }
        }
        return $book;
    }

    /**
     * @param Book $book
     */
    public function createBook(Book $book): void
    {
        $this->bookRepository->save($book);
        if ($this->authorRepository instanceof WarmRepositoryInterface) {
            // We reset author in warm cache-repository (as he should have to reload books).
            $this->authorRepository->reset($book->authorId);

The method reset() does not exist on LibraryCatalog\Service\Repository\AuthorRepositoryInterface. It seems like you code against a sub-type of LibraryCatalog\Service\Repository\AuthorRepositoryInterface such as LibraryCatalog\Infrastructure\Persistence\AuthorRepositoryRedis.

        }
    }

    /**
     * @return AuthorRepositoryInterface
     */
    public function getAuthorRepository(): AuthorRepositoryInterface
    {
        return $this->authorRepository;
    }
}