DataOHLCVBasicTest::pairs() - Code Metrics - Inspection of "locale disabled" - alecrabbit/twrb-php-components - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 62401f...daf94f )

by Alec

created 2018-11-15 13:27 UTC

DataOHLCVBasicTest::pairs() B

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	60
Code Lines	58

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	58
nc	1
nop	0
dl	0
loc	60
rs	8.9163
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * User: alec
 * Date: 31.10.18
 * Time: 16:33
 */

namespace Unit;


use AlecRabbit\DataOHLCV;
use PHPUnit\Framework\TestCase;

class DataOHLCVBasicTest extends TestCase
{
    /**
     * @test
     * @dataProvider sizes
     * @param $expected
     * @param $actual
     */
    public function basicSize($expected, $actual): void
    {
        $ohlcv = new DataOHLCV('btc_usd', $actual);
        $this->assertEquals($expected, $ohlcv->getSize());
    }

    /**
     * @test
     * @dataProvider pairs
     * @param $expected
     * @param $actual
     */
    public function basicPair($expected,$actual): void
    {
        $ohlcv = new DataOHLCV($actual, 10);
        $this->assertEquals($expected, $ohlcv->getPair());

    }

    public function sizes(): array
    {
        return [
            [500, 500],
            [50, 50],
            [10, 0],
            [999,999],
            [1000, 1000],
            [1001, 1001],
            [1440, 1441],
            [1440, 10000],
        ];
    }

    public function pairs(): array
    {
        return [
            ['btc_usd','btc_usd',],
            ['btc_eur','btc_eur',],
            ['btc_rur','btc_rur',],
            ['ltc_btc','ltc_btc',],
            ['ltc_usd','ltc_usd',],
            ['ltc_rur','ltc_rur',],
            ['nmc_btc','nmc_btc',],
            ['usd_rur','usd_rur',],
            ['eur_usd','eur_usd',],
            ['nvc_btc','nvc_btc',],
            ['ppc_btc','ppc_btc',],
            ['ltc_eur','ltc_eur',],
            ['nmc_usd','nmc_usd',],
            ['nvc_usd','nvc_usd',],
            ['ppc_usd','ppc_usd',],
            ['eur_rur','eur_rur',],
            ['dsh_btc','dsh_btc',],
            ['dsh_usd','dsh_usd',],
            ['eth_btc','eth_btc',],
            ['eth_usd','eth_usd',],
            ['eth_eur','eth_eur',],
            ['eth_ltc','eth_ltc',],
            ['eth_rur','eth_rur',],
            ['dsh_rur','dsh_rur',],
            ['dsh_eur','dsh_eur',],
            ['dsh_ltc','dsh_ltc',],
            ['dsh_eth','dsh_eth',],
            ['bch_usd','bch_usd',],
            ['bch_btc','bch_btc',],
            ['bch_rur','bch_rur',],
            ['bch_eur','bch_eur',],
            ['bch_ltc','bch_ltc',],
            ['bch_eth','bch_eth',],
            ['bch_dsh','bch_dsh',],
            ['zec_btc','zec_btc',],
            ['zec_usd','zec_usd',],
            ['usdet_usd','usdet_usd',],
            ['ruret_rur','ruret_rur',],
            ['euret_eur','euret_eur',],
            ['btcet_btc','btcet_btc',],
            ['ltcet_ltc','ltcet_ltc',],
            ['ethet_eth','ethet_eth',],
            ['nmcet_nmc','nmcet_nmc',],
            ['nvcet_nvc','nvcet_nvc',],
            ['ppcet_ppc','ppcet_ppc',],
            ['dshet_dsh','dshet_dsh',],
            ['bchet_bch','bchet_bch',],
            ['dsh_zec','dsh_zec',],
            ['eth_zec','eth_zec',],
            ['bch_zec','bch_zec',],
            ['zec_ltc','zec_ltc',],
            ['usdt_usd','usdt_usd',],
            ['btc_usdt','btc_usdt',],
            ['xmr_usd','xmr_usd',],
            ['xmr_btc','xmr_btc',],
            ['xmr_eth','xmr_eth',],
            ['xmr_rur','xmr_rur',],
        ];
    }
}

1			<?php
2			/**
3			* User: alec
4			* Date: 31.10.18
5			* Time: 16:33
6			*/
7
8			namespace Unit;
9
10
11			use AlecRabbit\DataOHLCV;
12			use PHPUnit\Framework\TestCase;
13
14			class DataOHLCVBasicTest extends TestCase
15			{
16			/**
17			* @test
18			* @dataProvider sizes
19			* @param $expected
20			* @param $actual
21			*/
22			public function basicSize($expected, $actual): void
23			{
24			$ohlcv = new DataOHLCV('btc_usd', $actual);
25			$this->assertEquals($expected, $ohlcv->getSize());
26			}
27
28			/**
29			* @test
30			* @dataProvider pairs
31			* @param $expected
32			* @param $actual
33			*/
34			public function basicPair($expected,$actual): void
35			{
36			$ohlcv = new DataOHLCV($actual, 10);
37			$this->assertEquals($expected, $ohlcv->getPair());
38
39			}
40
41			public function sizes(): array
42			{
43			return [
44			[500, 500],
45			[50, 50],
46			[10, 0],
47			[999,999],
48			[1000, 1000],
49			[1001, 1001],
50			[1440, 1441],
51			[1440, 10000],
52			];
53			}
54
55			public function pairs(): array
56			{
57			return [
58			['btc_usd','btc_usd',],
59			['btc_eur','btc_eur',],
60			['btc_rur','btc_rur',],
61			['ltc_btc','ltc_btc',],
62			['ltc_usd','ltc_usd',],
63			['ltc_rur','ltc_rur',],
64			['nmc_btc','nmc_btc',],
65			['usd_rur','usd_rur',],
66			['eur_usd','eur_usd',],
67			['nvc_btc','nvc_btc',],
68			['ppc_btc','ppc_btc',],
69			['ltc_eur','ltc_eur',],
70			['nmc_usd','nmc_usd',],
71			['nvc_usd','nvc_usd',],
72			['ppc_usd','ppc_usd',],
73			['eur_rur','eur_rur',],
74			['dsh_btc','dsh_btc',],
75			['dsh_usd','dsh_usd',],
76			['eth_btc','eth_btc',],
77			['eth_usd','eth_usd',],
78			['eth_eur','eth_eur',],
79			['eth_ltc','eth_ltc',],
80			['eth_rur','eth_rur',],
81			['dsh_rur','dsh_rur',],
82			['dsh_eur','dsh_eur',],
83			['dsh_ltc','dsh_ltc',],
84			['dsh_eth','dsh_eth',],
85			['bch_usd','bch_usd',],
86			['bch_btc','bch_btc',],
87			['bch_rur','bch_rur',],
88			['bch_eur','bch_eur',],
89			['bch_ltc','bch_ltc',],
90			['bch_eth','bch_eth',],
91			['bch_dsh','bch_dsh',],
92			['zec_btc','zec_btc',],
93			['zec_usd','zec_usd',],
94			['usdet_usd','usdet_usd',],
95			['ruret_rur','ruret_rur',],
96			['euret_eur','euret_eur',],
97			['btcet_btc','btcet_btc',],
98			['ltcet_ltc','ltcet_ltc',],
99			['ethet_eth','ethet_eth',],
100			['nmcet_nmc','nmcet_nmc',],
101			['nvcet_nvc','nvcet_nvc',],
102			['ppcet_ppc','ppcet_ppc',],
103			['dshet_dsh','dshet_dsh',],
104			['bchet_bch','bchet_bch',],
105			['dsh_zec','dsh_zec',],
106			['eth_zec','eth_zec',],
107			['bch_zec','bch_zec',],
108			['zec_ltc','zec_ltc',],
109			['usdt_usd','usdt_usd',],
110			['btc_usdt','btc_usdt',],
111			['xmr_usd','xmr_usd',],
112			['xmr_btc','xmr_btc',],
113			['xmr_eth','xmr_eth',],
114			['xmr_rur','xmr_rur',],
115			];
116			}
117			}

alecrabbit / twrb-php-components

Push — master ( 62401f...daf94f )

DataOHLCVBasicTest::pairs() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like