alecrabbit /
php-traits
| Conditions | 10 |
| Paths | 11 |
| Total Lines | 23 |
| Code Lines | 15 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 12 |
| CRAP Score | 10 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 33 | 2 | protected function processException(\Throwable $e): void |
|
| 34 | { |
||
| 35 | 2 | if ($this->throwOnError) { |
|
| 36 | 1 | throw $e; |
|
| 37 | } |
||
| 38 | 1 | $hasDumpFunction = \function_exists('dump'); |
|
| 39 | 1 | if (\defined('APP_DEBUG') && APP_DEBUG) { |
|
| 40 | 1 | if (\defined('DEBUG_DUMP_EXCEPTION') && DEBUG_DUMP_EXCEPTION) { |
|
| 41 | 1 | $exceptionMessage = '[' . \get_class($e) . '] ' . $e->getMessage(); |
|
| 42 | 1 | if ($hasDumpFunction) { |
|
| 43 | 1 | dump($exceptionMessage, $e->getTraceAsString()); |
|
| 44 | } else { |
||
| 45 | // @codeCoverageIgnoreStart |
||
| 46 | var_dump($exceptionMessage, $e->getTraceAsString()); |
||
|
1 ignored issue
–
show
|
|||
| 47 | // @codeCoverageIgnoreEnd |
||
| 48 | } |
||
| 49 | } |
||
| 50 | 1 | if (\defined('DEBUG_DUMP_EXCEPTION_CLASS') && DEBUG_DUMP_EXCEPTION_CLASS) { |
|
| 51 | 1 | if ($hasDumpFunction) { |
|
| 52 | 1 | dump($e); |
|
| 53 | } else { |
||
| 54 | // @codeCoverageIgnoreStart |
||
| 55 | var_dump($e); |
||
| 56 | // @codeCoverageIgnoreEnd |
||
| 67 |
Loading history...