alecrabbit / php-console-spinner

src/Spinner/Container/DefinitionRegistry.php

<?php

declare(strict_types=1);

namespace AlecRabbit\Spinner\Container;

use AlecRabbit\Spinner\Container\Contract\IDefinitionRegistry;
use AlecRabbit\Spinner\Container\Contract\IServiceDefinition;
use ArrayObject;
use Traversable;

final class DefinitionRegistry implements IDefinitionRegistry
{
    private static ?IDefinitionRegistry $instance = null;

    /** @var ArrayObject<string, IServiceDefinition> */
    private readonly ArrayObject $definitions;

    private function __construct(
        ArrayObject $definitions = new ArrayObject(),
    ) {
        /** @var ArrayObject<string, IServiceDefinition> $definitions */
        $this->definitions = $definitions;

The property definitions is declared read-only in AlecRabbit\Spinner\Container\DefinitionRegistry.

    }

    public static function getInstance(): IDefinitionRegistry
    {
        if (self::$instance === null) {
            self::$instance = new self();
        }
        return self::$instance;

The expression return self::instance could return the type null which is incompatible with the type-hinted return AlecRabbit\Spinner\Container\Contract\IDefinitionRegistry. Consider adding an additional type-check to rule them out.

    }

    public function load(): Traversable
    {
        yield from $this->definitions;
    }

    public function bind(IServiceDefinition ...$serviceDefinitions): void
    {
        foreach ($serviceDefinitions as $serviceDefinition) {
            $this->definitions->offsetSet($serviceDefinition->getId(), $serviceDefinition);
        }
    }
}