AlecRabbit\Spinner\Core\Factory\WidgetSettingsFactory::createFromConfig()

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function createFromConfig(IWidgetConfig $config): IWidgetSettings
    {
        $config = $config->merge($this->settingsProvider->getWidgetConfig());

        return
            $this->widgetSettingsBuilder
                ->withLeadingSpacer($config->getLeadingSpacer())

It seems like $config->getLeadingSpacer() can also be of type null; however, parameter $frame of AlecRabbit\Spinner\Core\Builder\Settings\Contract\IWidgetSettingsBuilder::withLeadingSpacer() does only seem to accept AlecRabbit\Spinner\Contract\IFrame, maybe add an additional type check?

                ->withTrailingSpacer($config->getTrailingSpacer())

It seems like $config->getTrailingSpacer() can also be of type null; however, parameter $frame of AlecRabbit\Spinner\Core\Builder\Settings\Contract\IWidgetSettingsBuilder::withTrailingSpacer() does only seem to accept AlecRabbit\Spinner\Contract\IFrame, maybe add an additional type check?

                ->withStylePattern($config->getStylePattern())

It seems like $config->getStylePattern() can also be of type null; however, parameter $pattern of AlecRabbit\Spinner\Core\Builder\Settings\Contract\IWidgetSettingsBuilder::withStylePattern() does only seem to accept AlecRabbit\Spinner\Core\Pattern\Contract\IStylePattern, maybe add an additional type check?

                ->withCharPattern($config->getCharPattern())

It seems like $config->getCharPattern() can also be of type null; however, parameter $pattern of AlecRabbit\Spinner\Core\Builder\Settings\Contract\IWidgetSettingsBuilder::withCharPattern() does only seem to accept AlecRabbit\Spinner\Contract\Pattern\IPattern, maybe add an additional type check?

                ->build()
        ;