StreamReader::getContents() - Code Metrics - Inspection of "Remove getContents() method from ResourceReader" - alchemy-fr/resource-component - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 24969c...7fa6d5 )

by Thibaud

created 2016-03-21 19:48 UTC

StreamReader::getContents() A

↳ Parent: StreamReader::getContentsAsStream()

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

/*
 * This file is part of alchemy/resource-component.
 *
 * (c) Alchemy <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Alchemy\Resource\Reader;

use Alchemy\Resource\ResourceReader;
use Alchemy\Resource\ResourceUri;

class StreamReader implements ResourceReader
{
    /**
     * @var ResourceUri
     */
    private $resource;

    /**
     * @var resource[]
     */
    private $streams = [];

    /**
     * @param ResourceUri $resource
     */
    public function __construct(ResourceUri $resource)
    {
        $this->resource = $resource;
    }

    public function __destruct()
    {
        foreach ($this->streams as $stream) {
            @fclose($stream);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
    }

    /**
     * @return resource
     */
    public function getContentsAsStream()
    {
        $stream = @fopen($this->resource, 'r');

        if ($stream === false) {
            throw new \RuntimeException('Unable to open stream resource for ' . $this->resource);
        }

        $this->streams[] = $stream;

        return $stream;
    }
}


1		<?php
2
3		/*
4		* This file is part of alchemy/resource-component.
5		*
6		* (c) Alchemy <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Alchemy\Resource\Reader;
13
14		use Alchemy\Resource\ResourceReader;
15		use Alchemy\Resource\ResourceUri;
16
17		class StreamReader implements ResourceReader
18		{
19		/**
20		* @var ResourceUri
21		*/
22		private $resource;
23
24		/**
25		* @var resource[]
26		*/
27		private $streams = [];
28
29		/**
30		* @param ResourceUri $resource
31		*/
32	16	public function __construct(ResourceUri $resource)
33		{
34	16	$this->resource = $resource;
35	16	}
36
37	16	public function __destruct()
38		{
39	16	foreach ($this->streams as $stream) {
40	8	@fclose($stream);
		0 ignored issues – show Security Best Practice introduced 2016-03-21 18:28 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
41	12	}
42	16	}
43
44		/**
45		* @return resource
46		*/
47	12	public function getContentsAsStream()
48		{
49	12	$stream = @fopen($this->resource, 'r');
50
51	12	if ($stream === false) {
52	4	throw new \RuntimeException('Unable to open stream resource for ' . $this->resource);
53		}
54
55	8	$this->streams[] = $stream;
56
57	8	return $stream;
58		}
59		}
60

alchemy-fr / resource-component

Push — master ( 24969c...7fa6d5 )

StreamReader::getContents() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like