Alchemy\Resource\Metadata\ArrayMetadataIterator

Complexity

Total Complexity

6

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	next()	0	4	1
A	key()	0	4	1
A	valid()	0	4	1
A	rewind()	0	4	1
A	current()	0	4	1

<?php

namespace Alchemy\Resource\Metadata;

use Assert\Assertion;

class ArrayMetadataIterator implements MetadataIterator
{
    /**
     * @var Metadata[]
     */
    private $resources;

    /**
     * @param Metadata[] $metadataResources
     */
    public function __construct(array $metadataResources)
    {
        Assertion::allIsInstanceOf($metadataResources, Metadata::class);

        $this->resources = $metadataResources;
    }

    /**
     * (PHP 5 &gt;= 5.0.0)<br/>
     * Move forward to next element
     * @link http://php.net/manual/en/iterator.next.php
     * @return void Any returned value is ignored.
     */
    public function next()
    {
        next($this->resources);
    }

    /**
     * (PHP 5 &gt;= 5.0.0)<br/>
     * Return the key of the current element
     * @link http://php.net/manual/en/iterator.key.php
     * @return mixed scalar on success, or null on failure.
     */
    public function key()
    {
        return key($this->resources);
    }

    /**
     * (PHP 5 &gt;= 5.0.0)<br/>
     * Checks if current position is valid
     * @link http://php.net/manual/en/iterator.valid.php
     * @return boolean The return value will be casted to boolean and then evaluated.
     * Returns true on success or false on failure.
     */
    public function valid()
    {
        return key($this->resources) !== null;
    }

    /**
     * (PHP 5 &gt;= 5.0.0)<br/>
     * Rewind the Iterator to the first element
     * @link http://php.net/manual/en/iterator.rewind.php
     * @return void Any returned value is ignored.
     */
    public function rewind()
    {
        reset($this->resources);
    }

    /**
     * @return Metadata
     */
    public function current()
    {
        return current($this->resources);

The expression current($this->resources); of type Alchemy\Resource\Metadata\Metadata|false adds false to the return on line 74 which is incompatible with the return type declared by the interface Alchemy\Resource\Metadata\MetadataIterator::current of type Alchemy\Resource\Metadata\Metadata. It seems like you forgot to handle an error condition.

    }
}