Alchemy\Resource\Reader\StreamReader

Complexity

Total Complexity

5

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	__destruct()	0	6	2
A	getContentsAsStream()	0	12	2

<?php

/*
 * This file is part of alchemy/resource-component.
 *
 * (c) Alchemy <info@alchemy.fr>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Alchemy\Resource\Reader;

use Alchemy\Resource\ResourceReader;
use Alchemy\Resource\ResourceUri;

class StreamReader implements ResourceReader
{
    /**
     * @var ResourceUri
     */
    private $resource;

    /**
     * @var resource[]
     */
    private $streams = [];

    /**
     * @param ResourceUri $resource
     */
    public function __construct(ResourceUri $resource)
    {
        $this->resource = $resource;
    }

    public function __destruct()
    {
        foreach ($this->streams as $stream) {
            @fclose($stream);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        }
    }

    /**
     * @return resource
     */
    public function getContentsAsStream()
    {
        $stream = @fopen($this->resource->getUri(), 'r');

        if ($stream === false) {
            throw new \RuntimeException('Unable to open ' . $this->resource->getUri() . ' for reading');
        }

        $this->streams[] = $stream;

        return $stream;
    }
}