Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
15 | class AmqpMessageQueue implements MessageQueue, LoggerAwareInterface |
||
16 | { |
||
17 | /** |
||
18 | * @var \AMQPExchange |
||
19 | */ |
||
20 | private $exchange; |
||
21 | |||
22 | /** |
||
23 | * @var \AMQPQueue |
||
24 | */ |
||
25 | private $queue; |
||
26 | |||
27 | /** |
||
28 | * @var LoggerInterface |
||
29 | */ |
||
30 | private $logger; |
||
31 | |||
32 | 20 | public function __construct(\AMQPExchange $exchange, \AMQPQueue $queue) |
|
38 | |||
39 | /** |
||
40 | * Sets a logger instance on the object |
||
41 | * |
||
42 | * @param LoggerInterface $logger |
||
43 | * @return null |
||
44 | */ |
||
45 | 4 | public function setLogger(LoggerInterface $logger) |
|
49 | |||
50 | /** |
||
51 | * @param Message $message |
||
52 | */ |
||
53 | 12 | public function publish(Message $message) |
|
64 | |||
65 | /** |
||
66 | * @param MessageHandlerResolver $resolver |
||
67 | */ |
||
68 | 12 | public function handle(MessageHandlerResolver $resolver) |
|
69 | { |
||
70 | 12 | $this->logger->debug('Consuming messages from AMQP queue: ' . $this->queue->getName()); |
|
71 | |||
72 | 12 | $this->queue->consume(function (\AMQPEnvelope $envelope, \AMQPQueue $queue) use ($resolver) { |
|
73 | 12 | $message = new Message($envelope->getBody(), $envelope->getCorrelationId()); |
|
74 | 12 | $handler = $resolver->resolveHandler($message); |
|
75 | |||
76 | try { |
||
77 | 12 | $this->logger->debug('Dispatching message to handler'); |
|
78 | 12 | $handler->handle($message); |
|
79 | 8 | $this->ackMessage($queue, $envelope); |
|
80 | 10 | } catch (MessageHandlingException $exception) { |
|
81 | 4 | $this->logger->error('Caught exception while handling message: ' . $exception->getMessage()); |
|
82 | 4 | $this->nackMessage($queue, $envelope); |
|
83 | } |
||
84 | |||
85 | 12 | return false; |
|
86 | 12 | }, AMQP_NOPARAM, Uuid::uuid4()); |
|
87 | 12 | } |
|
88 | |||
89 | 8 | View Code Duplication | private function ackMessage(\AMQPQueue $queue, \AMQPEnvelope $envelope) |
98 | |||
99 | 4 | View Code Duplication | private function nackMessage(\AMQPQueue $queue, \AMQPEnvelope $envelope) |
108 | } |
||
109 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.