Alchemy\Phraseanet\Helper\InstanceHelperRegistry

Complexity

Total Complexity

8

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

94.44%

Importance

Changes	3
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	addHelper()	0	4	1
A	hasHelper()	0	4	1
A	getHelper()	0	12	3
A	setDefaultHelper()	0	4	1
A	getDefaultHelper()	0	8	2

<?php

namespace Alchemy\Phraseanet\Helper;

class InstanceHelperRegistry
{

    private $defaultInstance = null;

    /**
     * @var InstanceHelper[]
     */
    private $instanceHelpers = [];

    public function addHelper($name, InstanceHelper $helper)
    {
        $this->instanceHelpers[$name] = $helper;
    }

    public function hasHelper($name)
    {
        return isset($this->instanceHelpers[$name]);
    }

    /**
     * @param $name
     * @return InstanceHelper
     */
    public function getHelper($name)
    {
        if ($name == null) {
            return $this->getDefaultHelper();

The expression $this->getDefaultHelper(); of type Alchemy\Phraseanet\Helper\InstanceHelper|false adds false to the return on line 32 which is incompatible with the return type documented by Alchemy\Phraseanet\Helper\InstanceHelperRegistry::getHelper of type Alchemy\Phraseanet\Helper\InstanceHelper. It seems like you forgot to handle an error condition.

        }

        if (! $this->hasHelper($name)) {
            throw new \OutOfBoundsException("Helper '$name' is not defined.");
        }

        return $this->instanceHelpers[$name];
    }

    public function setDefaultHelper($name)
    {
        $this->defaultInstance = $name;
    }

    public function getDefaultHelper()
    {
        if ($this->defaultInstance == null) {
            return reset($this->instanceHelpers);
        }

        return $this->getHelper($this->defaultInstance);
    }
}